-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude JDK23+ openj9 xmac testing on mac10 #5686
Conversation
Keep this PR in draft until openj9 jenkins xmac machine labels are standardized (i.e., set to the major version). |
related: eclipse-openj9/openj9#19694 and infrastructure/issues/9756 Signed-off-by: Lan Xia <[email protected]>
openj9 machine label |
openj9 jenkins: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3893/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We'll need the same change in the 1.0.4 branch. |
@@ -302,6 +302,11 @@ timestamps{ | |||
LABEL += "&&!sw.os.cent.7" | |||
} | |||
|
|||
// JDK23+ isn't supported on machines prior to Mac 11 https://github.com/eclipse-openj9/openj9/issues/19694 | |||
if (params.JDK_IMPL == "openj9" && PLATFORM == "x86-64_mac" && params.JDK_VERSION && params.JDK_VERSION.toInteger() >= 23) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this is used with jdknext, is JDK_VERSION
"24" or "next"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "next" is a concept only used in the OpenJ9 pipelines. The OpenJ9 pipelines fixed this via https://github.com/eclipse-openj9/openj9/blob/master/buildenv/jenkins/variables/defaults.yml#L391
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but the problem here will be if JDK_VERSION
is "next", that toInteger()
will throw a NumberFormatException
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, trying it via https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/617/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will get NumberFormatException when JDK_VERSION = next. I will fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But where did "8" come from in a job testing Java 24 (jdknext)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No related problem in that build. Afaik, JDK_VERSION
is not set to next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't get to that test because PLATFORM == "x86-64_mac"
was not true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, with the correct platform we get NumberFormatException
java.lang.NumberFormatException: For input string: "next"
at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.base/java.lang.Integer.parseInt(Integer.java:652)
at java.base/java.lang.Integer.valueOf(Integer.java:983)
at org.codehaus.groovy.runtime.StringGroovyMethods.toInteger(StringGroovyMethods.java:3319)
related: eclipse-openj9/openj9#19694 and infrastructure/issues/9756