Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sha265 name to sha256 #617

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/__fixtures__/hooks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
package: {
name: "name_mock.tar.gz",
link: new URL("https://link_mock"),
sha265sum: `sha265sum_mock${id}`,
sha256sum: `sha256sum_mock${id}`,

Check warning on line 63 in src/__fixtures__/hooks.tsx

View check run for this annotation

Codecov / codecov/patch

src/__fixtures__/hooks.tsx#L63

Added line #L63 was not covered by tests
sha256sum_link: new URL("https://sha256sum_link_mock"),
signature_link: new URL("https://signature_link_mock"),
},
Expand All @@ -69,7 +69,7 @@
{
name: "installer_name_mock.msi",
link: new URL("https://installer_link_mock"),
sha265sum: "installer_sha265sum_mock",
sha256sum: "installer_sha256sum_mock",

Check warning on line 72 in src/__fixtures__/hooks.tsx

View check run for this annotation

Codecov / codecov/patch

src/__fixtures__/hooks.tsx#L72

Added line #L72 was not covered by tests
sha256sum_link: new URL("https://installer_sha256sum_link_mock"),
signature_link: new URL("https://installer_signature_link_mock"),
},
Expand Down Expand Up @@ -114,7 +114,7 @@
package: {
name: "name_mock.tar.gz",
link: new URL("https://link_mock"),
checksum: "sha265sum_mock",
checksum: "sha256sum_mock",
checksum_link: new URL("https://sha256sum_link_mock"),
metadata_link: new URL("https://metadata_link_mock"),
signature_link: new URL("https://signature_link_mock"),
Expand All @@ -125,7 +125,7 @@
? {
name: "installer_name_mock.msi",
link: new URL("https://installer_link_mock"),
checksum: "installer_sha265sum_mock",
checksum: "installer_sha256sum_mock",
checksum_link: new URL("https://installer_sha256sum_link_mock"),
metadata_link: new URL("https://installer_metadata_link_mock"),
signature_link: new URL("https://installer_signature_link_mock"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

exports[`fetchLatestForOS > binary URL is set correctly 1`] = `
{
"checksum": "sha265sum_mock",
"checksum": "sha256sum_mock",
"link": "https://link_mock/",
"release_name": "release_name_mock",
}
`;

exports[`fetchLatestForOS > installer is returned if available 1`] = `
{
"checksum": "installer_sha265sum_mock",
"checksum": "installer_sha256sum_mock",
"link": "https://installer_link_mock/",
"release_name": "release_name_mock",
}
Expand Down
4 changes: 2 additions & 2 deletions src/hooks/fetchMarketplace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ export interface MarketplaceRelease {
package: {
name: string
link: URL
sha265sum: string
sha256sum: string
sha256sum_link: URL
signature_link: URL
}
installer?: [
{
name: string
link: URL
sha265sum: string
sha256sum: string
sha256sum_link: URL
signature_link: URL
},
Expand Down
4 changes: 2 additions & 2 deletions src/pages/__tests__/__snapshots__/download.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ exports[`Download page > renders correctly - vendor 1`] = `
>
<a
class="btn btn-lg btn-outline-dark m-2"
data-bs-checksum="sha265sum_mock"
data-bs-checksum="sha256sum_mock"
data-bs-target="#checksumModal"
data-bs-toggle="modal"
href=""
Expand Down Expand Up @@ -218,7 +218,7 @@ exports[`Download page > renders correctly 1`] = `
>
<a
class="btn btn-lg btn-outline-dark m-2"
data-bs-checksum="sha265sum_mock"
data-bs-checksum="sha256sum_mock"
data-bs-target="#checksumModal"
data-bs-toggle="modal"
href=""
Expand Down
4 changes: 2 additions & 2 deletions src/pages/__tests__/download.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Download, { Head } from "../download"
const location = {
state: {
link: "https://fake-download.tar.gz",
checksum: "sha265sum_mock",
checksum: "sha256sum_mock",
os: "linux",
arch: "x64",
type: "jdk",
Expand Down Expand Up @@ -44,7 +44,7 @@ describe("Download page", () => {
const location = {
state: {
link: "https://fake-download.tar.gz",
checksum: "sha265sum_mock",
checksum: "sha256sum_mock",
os: "linux",
arch: "x64",
java_version: "1.0.0",
Expand Down