Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdk21u adoptium mirror repo #30

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

andrew-m-leonard
Copy link
Contributor

Create new jdk21u Adoptium mirror repository: https://github.com/adoptium/jdk21u

Signed-off-by: Andrew Leonard <[email protected]>
@github-actions

This comment has been minimized.

@netomi
Copy link
Contributor

netomi commented Sep 25, 2023

while looking at the change, I noticed this setting which is also enabled for the other mirror repos:

dependabot_security_updates_enabled: true,

I wonder if this makes sense for a mirror from openjdk and we should not disable that setting for all mirror repos. wdyt?

@andrew-m-leonard
Copy link
Contributor Author

while looking at the change, I noticed this setting which is also enabled for the other mirror repos:

dependabot_security_updates_enabled: true,

I wonder if this makes sense for a mirror from openjdk and we should not disable that setting for all mirror repos. wdyt?

@netomi I had to google what it meant, as I had just copied the previous mirrors, and yes I would agree, it would not make sense for automatic dependabot updates...

@netomi
Copy link
Contributor

netomi commented Sep 25, 2023

ok, I have updated the PR to disable dependabot alerts / updates for all mirrored repos. If you approve I merge and apply the changes.

@github-actions
Copy link

Diff for bc4a6e2:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization adoptium[id=adoptium]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="alpine-jdk8u"] {
!     dependabot_alerts_enabled                                = true -> false
!     dependabot_security_updates_enabled                      = true -> false
!   }

  
!   repository[name="jdk19u"] {
!     dependabot_alerts_enabled                                = true -> false
!     dependabot_security_updates_enabled                      = true -> false
!   }

  
!   repository[name="jdk20u"] {
!     dependabot_alerts_enabled                                = true -> false
!     dependabot_security_updates_enabled                      = true -> false
!   }

  
!   repository[name="jdk21"] {
!     dependabot_alerts_enabled                                = true -> false
!     dependabot_security_updates_enabled                      = true -> false
!   }

+   add repository[name="jdk21u"] {
+     allow_auto_merge                                         = false
+     allow_forking                                            = true
+     allow_merge_commit                                       = true
+     allow_rebase_merge                                       = true
+     allow_squash_merge                                       = true
+     allow_update_branch                                      = false
+     archived                                                 = false
+     default_branch                                           = "master"
+     delete_branch_on_merge                                   = false
+     dependabot_alerts_enabled                                = false
+     dependabot_security_updates_enabled                      = false
+     description                                              = null
+     gh_pages_build_type                                      = "disabled"
+     has_discussions                                          = false
+     has_issues                                               = true
+     has_projects                                             = true
+     has_wiki                                                 = true
+     homepage                                                 = null
+     is_template                                              = false
+     merge_commit_message                                     = "PR_TITLE"
+     merge_commit_title                                       = "MERGE_MESSAGE"
+     name                                                     = "jdk21u"
+     private                                                  = false
+     secret_scanning                                          = "disabled"
+     secret_scanning_push_protection                          = "disabled"
+     squash_merge_commit_message                              = "COMMIT_MESSAGES"
+     squash_merge_commit_title                                = "COMMIT_OR_PR_TITLE"
+     template_repository                                      = null
+     topics                                                   = []
+     web_commit_signoff_required                              = false
+   }
  
  Plan: 1 to add, 8 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization adoptium[id=adoptium]
--- original
+++ canonical
@@ -525,6 +525,7 @@
     orgs.newRepo('jdk17') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "JDK17 mirror. This source code is an unmodified mirror of source code obtained from OpenJDK https://github.com/openjdk/jdk17. It has been and may still be used to create builds that are untested and incompatible with the Java SE specification. You should not deploy or write to this code, but instead, use the tested and certified Java SE compatible version of the code that is available at https://www.adoptium.net."
       homepage: ""
       web_commit_signoff_required: false
@@ -542,6 +543,7 @@
     orgs.newRepo('jdk18') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "JDK18 mirror. This source code is an unmodified mirror of source code obtained from OpenJDK https://github.com/openjdk/jdk18. It has been and may still be used to create builds that are untested and incompatible with the Java SE specification. You should not deploy or write to this code, but instead use the tested and certified Java SE compatible version of the code that is available at https://adoptium.net."
       web_commit_signoff_required: false
     }
@@ -557,6 +559,7 @@
     orgs.newRepo('jdk19') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "jdk19 repository"
       secret_scanning: "disabled"
       web_commit_signoff_required: false
@@ -574,6 +577,7 @@
     orgs.newRepo('jdk20') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       secret_scanning: "disabled"
       web_commit_signoff_required: false
     }
@@ -621,6 +625,7 @@
     orgs.newRepo('jdk8u_hg') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "JDK8u mirror from mercurial from"
       homepage: "http://hg.openjdk.java.net/jdk8u/jdk8u/"
       web_commit_signoff_required: false

@andrew-m-leonard
Copy link
Contributor Author

ok, I have updated the PR to disable dependabot alerts / updates for all mirrored repos. If you approve I merge and apply the changes.

Yes, change looks good, thanks.

@netomi netomi merged commit 8159f96 into adoptium:main Sep 25, 2023
2 checks passed
@netomi
Copy link
Contributor

netomi commented Sep 25, 2023

repo has been created.

@andrew-m-leonard
Copy link
Contributor Author

@netomi I'm struggling to mirror clone and push our jdk21 repo to this new jdk21u repo:

anleonar@anleonar-mac jdk21.git % git push --mirror [email protected]:adoptium/jdk21u.git
Enter passphrase for key '/Users/anleonar/.ssh/id_rsa': 
Enumerating objects: 1346049, done.
Counting objects: 100% (1346049/1346049), done.
Delta compression using up to 10 threads
Compressing objects: 100% (254542/254542), done.
Writing objects: 100% (1346049/1346049), 1.07 GiB | 2.01 MiB/s, done.
Total 1346049 (delta 1000883), reused 1346049 (delta 1000883), pack-reused 0
remote: Resolving deltas: 100% (1000883/1000883), done.
send-pack: unexpected disconnect while reading sideband packet
fatal: the remote end hung up unexpectedly
Connection to github.com closed by remote host.

I suspect because the new jdk21u repo is not "empty", we have protection to prevent the mirror push ?
Can we re-create the repo, but as an "empty" repo please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants