Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Temurin project repo #25

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Create Temurin project repo #25

merged 2 commits into from
Sep 26, 2023

Conversation

tellison
Copy link
Contributor

Temurin project-level repository

Temurin project-level repository

Signed-off-by: Tim Ellison <[email protected]>
@github-actions

This comment has been minimized.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR - it was on my list before the October release so I definitely approve in principle.
Is it possible to create this repository for issues-only to begin with, unless there is an existing need to store particular files in here (as I recall from the original discussinos this was primarile required so we had the release tracking issues in a temurin project repository instead of the top level Adoptium one)?

@tellison
Copy link
Contributor Author

I do envisage using the code repo to store Temurin all-releases info such as the vulnerability disclosure report.

@netomi
Copy link
Contributor

netomi commented Sep 25, 2023

In order to prevent commits to the repo you could add a generic branch protection rule matching any branch with * which requires PRs and also blocks creations. Nobody would approve and merge them, so nothing could be pushed to the main branch.

@tellison
Copy link
Contributor Author

In order to prevent commits to the repo ...

We do wish to allow commits to the repo.

@tellison tellison marked this pull request as ready for review September 26, 2023 08:21
@tellison tellison requested review from a team as code owners September 26, 2023 08:21
@tellison
Copy link
Contributor Author

release code freeze over, so marking ready for review.

@github-actions
Copy link

Diff for 8159f96:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization adoptium[id=adoptium]
  there have been 4 validation infos, enable verbose output with '-v' to to display them.

+   add repository[name="temurin"] {
+     allow_auto_merge                                         = true
+     allow_forking                                            = true
+     allow_merge_commit                                       = false
+     allow_rebase_merge                                       = true
+     allow_squash_merge                                       = true
+     allow_update_branch                                      = false
+     archived                                                 = false
+     default_branch                                           = "main"
+     delete_branch_on_merge                                   = true
+     dependabot_alerts_enabled                                = true
+     dependabot_security_updates_enabled                      = true
+     description                                              = "Eclipse Temurin™ project assets"
+     gh_pages_build_type                                      = "disabled"
+     has_discussions                                          = false
+     has_issues                                               = true
+     has_projects                                             = true
+     has_wiki                                                 = false
+     homepage                                                 = "https://adoptium.net/temurin"
+     is_template                                              = false
+     merge_commit_message                                     = "PR_TITLE"
+     merge_commit_title                                       = "MERGE_MESSAGE"
+     name                                                     = "temurin"
+     private                                                  = false
+     secret_scanning                                          = "enabled"
+     secret_scanning_push_protection                          = "enabled"
+     squash_merge_commit_message                              = "COMMIT_MESSAGES"
+     squash_merge_commit_title                                = "COMMIT_OR_PR_TITLE"
+     template_repository                                      = null
+     topics                                                   = []
+     web_commit_signoff_required                              = false
+   }

+   add branch_protection_rule[pattern="main", repository="temurin"] {
+     allows_deletions                                         = false
+     allows_force_pushes                                      = false
+     blocks_creations                                         = false
+     bypass_force_push_allowances                             = []
+     bypass_pull_request_allowances                           = []
+     dismisses_stale_reviews                                  = false
+     is_admin_enforced                                        = false
+     lock_allows_fetch_and_merge                              = false
+     lock_branch                                              = false
+     pattern                                                  = "main"
+     push_restrictions                                        = []
+     require_last_push_approval                               = false
+     required_approving_review_count                          = "1"
+     required_status_checks                                   = [
+       "eclipse-eca-validation:eclipsefdn/eca"
+     ],
+     requires_code_owner_reviews                              = false
+     requires_commit_signatures                               = false
+     requires_conversation_resolution                         = false
+     requires_deployments                                     = false
+     requires_linear_history                                  = false
+     requires_pull_request                                    = true
+     requires_status_checks                                   = true
+     requires_strict_status_checks                            = false
+     restricts_pushes                                         = false
+     restricts_review_dismissals                              = false
+   }
  
  Plan: 2 to add, 0 to change, 0 to delete.
╷
│ Error: 'GitHubProvider' object has no attribute 'rest_api'
╵
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization adoptium[id=adoptium]
--- original
+++ canonical
@@ -525,6 +525,7 @@
     orgs.newRepo('jdk17') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "JDK17 mirror. This source code is an unmodified mirror of source code obtained from OpenJDK https://github.com/openjdk/jdk17. It has been and may still be used to create builds that are untested and incompatible with the Java SE specification. You should not deploy or write to this code, but instead, use the tested and certified Java SE compatible version of the code that is available at https://www.adoptium.net."
       homepage: ""
       web_commit_signoff_required: false
@@ -542,6 +543,7 @@
     orgs.newRepo('jdk18') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "JDK18 mirror. This source code is an unmodified mirror of source code obtained from OpenJDK https://github.com/openjdk/jdk18. It has been and may still be used to create builds that are untested and incompatible with the Java SE specification. You should not deploy or write to this code, but instead use the tested and certified Java SE compatible version of the code that is available at https://adoptium.net."
       web_commit_signoff_required: false
     }
@@ -557,6 +559,7 @@
     orgs.newRepo('jdk19') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "jdk19 repository"
       secret_scanning: "disabled"
       web_commit_signoff_required: false
@@ -574,6 +577,7 @@
     orgs.newRepo('jdk20') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       secret_scanning: "disabled"
       web_commit_signoff_required: false
     }
@@ -621,6 +625,7 @@
     orgs.newRepo('jdk8u_hg') {
       archived: true
       default_branch: "master"
+      dependabot_alerts_enabled: false
       description: "JDK8u mirror from mercurial from"
       homepage: "http://hg.openjdk.java.net/jdk8u/jdk8u/"
       web_commit_signoff_required: false
@@ -728,12 +733,14 @@
     }
     orgs.newRepo('temurin') {
       allow_auto_merge: true
+      allow_merge_commit: false
       allow_update_branch: false
       branch_protection_rules: [
         orgs.newBranchProtectionRule('main') {
           required_approving_review_count: 1
         }
       ]
+      default_branch: "main"
       dependabot_security_updates_enabled: true
       description: "Eclipse Temurin™ project assets"
       has_wiki: false

@netomi
Copy link
Contributor

netomi commented Sep 26, 2023

In order to prevent commits to the repo ...

We do wish to allow commits to the repo.

I was referring to this comment:

Is it possible to create this repository for issues-only to begin with

@netomi netomi merged commit 758679a into adoptium:main Sep 26, 2023
1 check passed
@netomi
Copy link
Contributor

netomi commented Sep 26, 2023

repo has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants