Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Althought moment.js works well with pikaday.js, it is now deprecated and has to be replaced with an alternative like
luxon
(basically its successor from same team).Packages installation
ember-auto-import
(andwebpack
) were necessary to useluxon
testdouble
was causing troubles withwebpack
and its use was pretty basic (so replaceable)ember-cli-babel
was causing issues withwebpack
Changes
luxon
follows ISO weekdays order so we had to change all aboutfirstDay
as Monday is now 0 (and not 1)luxon
uses other formatting tokens so we had to change all aboutformat
(https://moment.github.io/luxon/docs/manual/formatting.html#table-of-tokens)moment.js
but not withluxon
, we had to use pikaday methodstoString
andparse
(https://github.com/Pikaday/Pikaday#formatting)