allow full-screen snapshots #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-paper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Some tests with 'continue-on-error: true' have failed:
|
matthewhartstonge
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason for this change is because I wanted to add percy in #1296 but this is also required if you want the chrome "full screenshot" functionality to work. You can compare the preview build of this PR with the main demo app by doing the following
On main you'll see that scroll will be cut off and you can never get a full screenshot. This PR fixes that but needs to add some hacks to make the dialog inert. Personally I think it's a good tradeoff 👍