Ember 4.0 compatibility - drops support for Ember < 3.28

.eslintignore

@@ -19,4 +19,7 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.eslintrc.js

@@ -20,16 +20,9 @@ module.exports = {
     browser: true,
   },
   rules: {
-    'ember/no-actions-hash': 'off',
     'ember/no-classic-classes': 'off',
-    'ember/no-classic-components': 'off',
-    'ember/no-computed-properties-in-native-classes': 'off',
-    'ember/no-get': 'off',
     'ember/no-new-mixins': 'off',
-    'ember/no-volatile-computed-properties': 'off',
-    'ember/require-tagless-components': 'off',
     'ember/use-ember-data-rfc-395-imports': 'off',
-    'prettier/prettier': ['error', { singleQuote: true }],
   },
   overrides: [
     // node files
@@ -56,7 +49,7 @@ module.exports = {
       extends: ['plugin:node/recommended'],
     },
     {
-      // Test files:
+      // test files
       files: ['tests/**/*-test.{js,ts}'],
       extends: ['plugin:qunit/recommended'],
       rules: {

.github/workflows/ci.yml

@@ -57,17 +57,12 @@ jobs:
       fail-fast: false
       matrix:
         try-scenario:
-          - ember-lts-3.16
-          - ember-lts-3.20
-          - ember-lts-3.24
           - ember-lts-3.28
           - ember-4.0
           - ember-release
           - ember-beta
           - ember-canary
-          - ember-default-with-jquery
-          - ember-classic
-          - embroider-safe
+          # - embroider-safe
           # - embroider-optimized
 
     steps:

.gitignore

@@ -21,4 +21,7 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.npmignore

@@ -14,6 +14,7 @@
 /.eslintignore
 /.eslintrc.js
 /.git/
+/.github/
 /.gitignore
 /.prettierignore
 /.prettierrc.js
@@ -33,4 +34,7 @@
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.prettierignore

@@ -14,8 +14,12 @@
 /coverage/
 !.*
 .eslintcache
+.lint-todo/
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

addon/-private/ember-internals.js

@@ -1,17 +1,4 @@
-import Ember from 'ember';
-import { A } from '@ember/array';
-
-let __EMBER_METAL__;
-let emberMetalPaths = [
-  '@ember/-internals/metal', // ember-source from 3.10
-  '@ember/-internals/metal/index', // ember-source from 3.13
-];
-let metalPath = A(emberMetalPaths).find(
-  (path) => Ember.__loader.registry[path]
-);
-if (metalPath) {
-  __EMBER_METAL__ = Ember.__loader.require(metalPath);
-}
+import __EMBER_METAL__ from '@ember/-internals/metal/index';
 
 export function getDependentKeys(descriptorOrDecorator) {
   if (__EMBER_METAL__ && __EMBER_METAL__.descriptorForDecorator) {

addon/-private/ember-validator.js

@@ -3,7 +3,7 @@ import { validate as _validate } from 'ember-validators';
 
 export default Base.extend({
   validate() {
-    let result = _validate(this.get('_evType'), ...arguments);
+    let result = _validate(this._evType, ...arguments);
 
     if (result && typeof result === 'object') {
       return result.message

addon/-private/internal-result-object.js

@@ -1,4 +1,4 @@
-import EmberObject, { computed, set, get } from '@ember/object';
+import EmberObject, { computed, set } from '@ember/object';
 import { and, not, readOnly } from '@ember/object/computed';
 import { isNone } from '@ember/utils';
 import { makeArray } from '@ember/array';
@@ -20,7 +20,7 @@ export default EmberObject.extend({
   init() {
     this._super(...arguments);
 
-    if (this.get('isAsync')) {
+    if (this.isAsync) {
       this._handlePromise();
     }
   },
@@ -32,11 +32,11 @@ export default EmberObject.extend({
   isTruelyInvalid: and('isNotValidating', 'isInvalid'),
 
   isAsync: computed('_promise', function () {
-    return isPromise(get(this, '_promise'));
+    return isPromise(this._promise);
   }),
 
   messages: computed('message', function () {
-    return makeArray(get(this, 'message'));
+    return makeArray(this.message);
   }),
 
   error: computed(
@@ -46,11 +46,11 @@ export default EmberObject.extend({
     'message',
     'type',
     function () {
-      if (get(this, 'isInvalid')) {
+      if (this.isInvalid) {
         return ValidationError.create({
-          type: get(this, '_type'),
-          message: get(this, 'message'),
-          attribute: get(this, 'attribute'),
+          type: this._type,
+          message: this.message,
+          attribute: this.attribute,
         });
       }
 
@@ -59,11 +59,11 @@ export default EmberObject.extend({
   ),
 
   errors: computed('error', function () {
-    return makeArray(get(this, 'error'));
+    return makeArray(this.error);
   }),
 
   warningMessages: computed('warningMessage', function () {
-    return makeArray(get(this, 'warningMessage'));
+    return makeArray(this.warningMessage);
   }),
 
   warning: computed(
@@ -73,11 +73,11 @@ export default EmberObject.extend({
     'type',
     'warningMessage',
     function () {
-      if (get(this, 'isWarning') && !isNone(get(this, 'warningMessage'))) {
+      if (this.isWarning && !isNone(this.warningMessage)) {
         return ValidationError.create({
-          type: get(this, '_type'),
-          message: get(this, 'warningMessage'),
-          attribute: get(this, 'attribute'),
+          type: this._type,
+          message: this.warningMessage,
+          attribute: this.attribute,
         });
       }
 
@@ -86,13 +86,13 @@ export default EmberObject.extend({
   ),
 
   warnings: computed('warning', function () {
-    return makeArray(get(this, 'warning'));
+    return makeArray(this.warning);
   }),
 
   _handlePromise() {
     set(this, 'isValidating', true);
 
-    get(this, '_promise').finally(() => {
+    this._promise.finally(() => {
       set(this, 'isValidating', false);
     });
   },

addon/-private/result.js

@@ -1,13 +1,7 @@
 import { isNone } from '@ember/utils';
 
 import { isArray } from '@ember/array';
-import EmberObject, {
-  getProperties,
-  setProperties,
-  computed,
-  set,
-  get,
-} from '@ember/object';
+import EmberObject, { setProperties, computed, set } from '@ember/object';
 import { readOnly } from '@ember/object/computed';
 import ResultCollection from '../validations/result-collection';
 import WarningResultCollection from '../validations/warning-result-collection';
@@ -62,11 +56,8 @@ const Result = EmberObject.extend({
    * @type {Boolean}
    */
   _isReadOnly: computed('_result', function () {
-    let validations = get(this, '_result');
-    return (
-      validations instanceof ResultCollection ||
-      get(validations, 'isValidations')
-    );
+    let validations = this._result;
+    return validations instanceof ResultCollection || validations.isValidations;
   }).readOnly(),
 
   /**
@@ -187,19 +178,19 @@ const Result = EmberObject.extend({
     '_validator',
     '_resultOverride',
     function () {
+      let { model, attribute, _promise, _validator } = this;
+
       return (
-        get(this, '_resultOverride') ||
-        InternalResultObject.create(
-          getProperties(this, ['model', 'attribute', '_promise', '_validator'])
-        )
+        this._resultOverride ||
+        InternalResultObject.create({ model, attribute, _promise, _validator })
       );
     }
   ),
 
   init() {
     this._super(...arguments);
 
-    if (get(this, 'isAsync') && !get(this, '_isReadOnly')) {
+    if (this.isAsync && !this._isReadOnly) {
       this._handlePromise();
     }
   },
@@ -218,22 +209,22 @@ const Result = EmberObject.extend({
    * @param value
    */
   update(value) {
-    let result = get(this, '_result');
-    let attribute = get(this, 'attribute');
-    let isWarning = get(this, 'isWarning');
+    let result = this._result;
+    let attribute = this.attribute;
+    let isWarning = this.isWarning;
     let Collection = isWarning ? WarningResultCollection : ResultCollection;
 
     if (isNone(value)) {
       return this.update(false);
-    } else if (get(value, 'isValidations')) {
+    } else if (value.isValidations) {
       this._overrideResult(Collection.create({ attribute, content: [value] }));
     } else if (isArray(value)) {
       this._overrideResult(Collection.create({ attribute, content: value }));
-    } else if (!get(this, '_isReadOnly')) {
+    } else if (!this._isReadOnly) {
       this._overrideResult(undefined);
 
       if (typeof value === 'string') {
-        setProperties(get(this, '_result'), {
+        setProperties(this._result, {
           [isWarning ? 'warningMessage' : 'message']: value,
           isValid: isWarning ? true : false,
         });
@@ -261,7 +252,7 @@ const Result = EmberObject.extend({
    * @private
    */
   _handlePromise() {
-    get(this, '_promise')
+    this._promise
       .then(
         (value) => this.update(value),
         (value) => this.update(value)

addon/index.js

@@ -242,10 +242,10 @@ import Validator from './validations/validator';
  *     disabled: Ember.computed.not('model.meta.username.isEnabled'),
  *     min: Ember.computed.readOnly('model.meta.username.minLength'),
  *     max: Ember.computed.readOnly('model.meta.username.maxLength'),
- *     description: Ember.computed(function() {
+ *     description: Ember.computed('model', 'attribute', function() {
  *       // CPs have access to the `model` and `attribute`
  *       return this.get('model').generateDescription(this.get('attribute'));
- *     }).volatile() // Disable caching and force recompute on every get call
+ *     })
  *   })
  * });
  * ```

addon/utils/meta-data.js

@@ -1,4 +1,4 @@
-import Ember from 'ember';
+import { meta } from '@ember/-internals/meta';
 
 let id = 0;
 const dataKey = symbol('data');
@@ -8,7 +8,7 @@ function symbol(key) {
 }
 
 function getData(obj, s) {
-  let m = Ember.meta(obj);
+  let m = meta(obj);
   let data = m[dataKey];
 
   if (data) {
@@ -17,7 +17,7 @@ function getData(obj, s) {
 }
 
 function setData(obj, s, value) {
-  let m = Ember.meta(obj);
+  let m = meta(obj);
   let data = (m[dataKey] = m[dataKey] || {});
 
   data[s] = value;

addon/utils/utils.js

@@ -1,17 +1,19 @@
 import ArrayProxy from '@ember/array/proxy';
 import ObjectProxy from '@ember/object/proxy';
 import { isHTMLSafe } from '@ember/template';
-import EmberObject, { get } from '@ember/object';
+import EmberObject from '@ember/object';
 import { typeOf } from '@ember/utils';
 import { A as emberArray, isArray } from '@ember/array';
+import require from 'require';
 
-import Ember from 'ember';
-import requireModule from 'ember-require-module';
+function requireModule(module, exportName = 'default') {
+  if (require.has(module)) {
+    return require(module)[exportName];
+  }
+}
 
 const DS = requireModule('ember-data');
 
-const { canInvoke } = Ember;
-
 export { getDependentKeys, isDescriptor } from '../-private/ember-internals';
 
 export function unwrapString(s) {
@@ -23,13 +25,19 @@ export function unwrapString(s) {
 }
 
 export function unwrapProxy(o) {
-  return isProxy(o) ? unwrapProxy(get(o, 'content')) : o;
+  return isProxy(o) ? unwrapProxy(o.content) : o;
 }
 
 export function isProxy(o) {
   return !!(o && (o instanceof ObjectProxy || o instanceof ArrayProxy));
 }
 
+function canInvoke(obj, methodName) {
+  return (
+    obj !== null && obj !== undefined && typeof obj[methodName] === 'function'
+  );
+}
+
 export function isPromise(p) {
   return !!(p && canInvoke(p, 'then'));
 }
@@ -57,7 +65,7 @@ export function isObject(o) {
 
 export function isValidatable(value) {
   let v = unwrapProxy(value);
-  return isDsModel(v) ? !get(v, 'isDeleted') : true;
+  return isDsModel(v) ? !v.isDeleted : true;
 }
 
 export function getValidatableValue(value) {