Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functional style template transform #714

Merged

Conversation

fsmanuel
Copy link
Contributor

@fsmanuel fsmanuel commented Jun 29, 2022

As a followup on #712 this PR tries to get rid of a lot of deprecations.

@fsmanuel fsmanuel force-pushed the v-get-template-transform branch 2 times, most recently from b2b86e7 to 60a59e0 Compare June 29, 2022 15:37
@fsmanuel fsmanuel force-pushed the v-get-template-transform branch from 50a68fc to cd40704 Compare June 29, 2022 16:15
@fsmanuel fsmanuel mentioned this pull request Jul 7, 2022
14 tasks
@fsmanuel
Copy link
Contributor Author

fsmanuel commented Jul 7, 2022

@NullVoxPopuli can you do a review? I opened #716 to discuss how we should release it because to support ember 4 we need to do more to get the tests green.

@NullVoxPopuli
Copy link
Contributor

Sorry I haven't gotten to this -- I'll try to remember tomorrow

@fsmanuel
Copy link
Contributor Author

fsmanuel commented Jul 8, 2022

@NullVoxPopuli just a friendly reminder. Thanks for taking care!

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@NullVoxPopuli NullVoxPopuli merged commit a9c389d into adopted-ember-addons:master Jul 8, 2022
@fsmanuel fsmanuel deleted the v-get-template-transform branch July 8, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants