feat(breaking): upgrade to ember 3.28 #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drops node 10 support - drops supprt for Ember < 3.24
|
hey @jderr-mx! It's been a while since I last contributed here, thanks for maintaining this add on! I've made these changes to get the add on near the latest ember-cli (I can follow up with an ember-cli 4 PR after) and get this repo on GitHub actions. I've been running this code in a production app for about 2 weeks and have not noticed any changes in the issue reporting to bugsnag. If you get a moment would you mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Github actions too. Referenced: #120 and #119
I believe this means users will be able to upgrade to Ember 4.
I've been running this in a production app for today and it appears to work as before.