Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify using Node buffer by importing it #91

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Specify using Node buffer by importing it #91

merged 1 commit into from
Oct 17, 2024

Conversation

McSneaky
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It makes easier to use Adonis HTTP module across different JS runtimes

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

@RomainLanz Looks all good to be merged?

RomainLanz
RomainLanz approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@RomainLanz RomainLanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomainLanz RomainLanz merged commit 17e5d37 into adonisjs:7.x Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainLanz RomainLanz RomainLanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McSneaky @thetutlage @RomainLanz