Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify using Node buffer by importing it #90

Closed
wants to merge 2 commits into from

Conversation

McSneaky
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It makes easier to use Adonis HTTP module across different JS runtimes

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@RomainLanz
Copy link
Member

Hey @McSneaky! πŸ‘‹πŸ»

Thanks for the PR! May you change your " to ' and move this import at the top?

@McSneaky
Copy link
Contributor Author

Sure, lemme see how to edit it.. Was using Github web UI

@RomainLanz
Copy link
Member

Great! We are still missing the change for the test file. Otherwise CI will fail. πŸ˜„

Copy link
Contributor Author

@McSneaky McSneaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move Node buffer import to top

@McSneaky
Copy link
Contributor Author

^ was supposed to be commit message..

Lemme open another PR and do it from local all correctly.. Using Github "." is kinda confusing when using it for existing PRs and forks..

@McSneaky McSneaky closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants