docs: S2 release notes #7406
Merged
docs: S2 release notes #7406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Nov 20, 2024
LFDanLu
commented
Nov 20, 2024
|
|
||
| * [Dialog](?path=/docs/dialog--docs) – a modal dialog with a standard layout with slots for the heading, content, hero image, button group, etc. This corresponds to the previous `type="modal"` API. | ||
| * [FullscreenDialog](?path=/docs/fullscreendialog--docs) – a fullscreen or takeover modal, similar to a Dialog but with different slots and layout. This corresponds to the previous `type="fullscreen"` and `type="fullscreenTakeover"` APIs. | ||
| * [CustomDialog](?path=/docs/customdialog--docs) – a modal dialog with a completely custom layout. It can have default padding or go edge-to-edge. No built-in slots are provided, the layout is entirely up to you. |
There was a problem hiding this comment.
I noticed that padding is removed from the props table in the storybook intentionally (probably because it makes the story look strange when applied), but are we worried about discoverablity?
devongovett
reviewed
Nov 20, 2024
| * [Popover](?path=/docs/popover--docs) | ||
| * [ToggleButtonGroup](?path=/docs/togglebuttongroup--docs) | ||
|
|
||
| ### Updates |
There was a problem hiding this comment.
hmm, I think those are pretty important so I'll put it right after the dialog summary blurb
There was a problem hiding this comment.
also supporting arbitrary pixel sizes #7385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP