fix: Revert displaying popovers as modals on mobile for now #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
previously approved these changes
Nov 19, 2024
yihuiliao
reviewed
Nov 19, 2024
| import {style} from '../style' with {type: 'macro'}; | ||
| import {StyleString} from '../style/types' with {type: 'macro'}; | ||
| import {useDOMRef, useIsMobileDevice} from '@react-spectrum/utils'; | ||
| import {useDOMRef} from '@react-spectrum/utils'; | ||
|
|
||
| export interface PopoverProps extends UnsafeStyles, Omit<AriaPopoverProps, 'arrowSize' | 'isNonModal' | 'arrowBoundaryOffset' | 'isKeyboardDismissDisabled' | 'shouldCloseOnInteractOutside' | 'shouldUpdatePosition'> { |
There was a problem hiding this comment.
should we get rid of the mobileType prop for now if we're not showing popovers as modals on mobile?
## API Changes
@react-spectrum/s2/@react-spectrum/s2:Popover Popover {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode | (DialogRenderProps) => ReactNode
containerPadding?: number = 12
crossOffset?: number = 0
hideArrow?: boolean = false
id?: string | undefined
- mobileType?: 'modal' | 'fullscreen' | 'fullscreenTakeover'
offset?: number = 8
placement?: Placement = 'bottom'
role?: 'dialog' | 'alertdialog' = 'dialog'
shouldFlip?: boolean = true
slot?: string | null
styles?: StylesProp
}/@react-spectrum/s2:PopoverProps PopoverProps {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
UNSTABLE_portalContainer?: Element = document.body
boundaryElement?: Element = document.body
children?: ReactNode | ((PopoverRenderProps & {
defaultChildren: ReactNode | undefined
})) => ReactNode
className?: string | ((PopoverRenderProps & {
defaultClassName: string | undefined
})) => string
containerPadding?: number = 12
crossOffset?: number = 0
defaultOpen?: boolean
hideArrow?: boolean = false
isEntering?: boolean
isExiting?: boolean
isOpen?: boolean
maxHeight?: number
- mobileType?: 'modal' | 'fullscreen' | 'fullscreenTakeover'
offset?: number = 8
onOpenChange?: (boolean) => void
placement?: Placement = 'bottom'
scrollRef?: RefObject<Element | null> = overlayRef
size?: 'S' | 'M' | 'L'
slot?: string | null
style?: CSSProperties | ((PopoverRenderProps & {
defaultStyle: CSSProperties
})) => CSSProperties | undefined
styles?: StyleString
trigger?: string
triggerRef?: RefObject<Element | null>
} |
yihuiliao
approved these changes
Nov 19, 2024
LFDanLu
approved these changes
Nov 19, 2024
ktabors
approved these changes
Nov 19, 2024
| @@ -126,6 +123,9 @@ let popover = style({ | |||
| L: 576 | |||
| } | |||
| }, | |||
| // Don't be larger than full screen minus 2 * containerPadding | |||
| maxWidth: '[calc(100vw - 24px)]', | |||
There was a problem hiding this comment.
If there are scrollbars showing, this will still position and look okay, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we implement trays, we won't display popovers as modals on mobile. Also includes some example improvements, and fixes #7352 (comment)