Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rum-explorer) conversions can be tuned in a headless mode #524

Closed
wants to merge 7 commits into from

Conversation

akalfas
Copy link
Collaborator

@akalfas akalfas commented May 26, 2024

It provides a headless alternative for #523 - will still need some sort of a ux on top.

tools/rum/cruncher.js Show resolved Hide resolved
@akalfas akalfas requested a review from trieloff May 27, 2024 13:29
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review in progress.

tools/rum/cruncher.js Outdated Show resolved Hide resolved
tools/rum/slicer.js Outdated Show resolved Hide resolved
@akalfas akalfas requested a review from trieloff May 28, 2024 05:46
@akalfas akalfas force-pushed the configurable-conversions branch 2 times, most recently from fd8d33b to f19d8a7 Compare June 3, 2024 09:06
@akalfas
Copy link
Collaborator Author

akalfas commented Jun 4, 2024

@trieloff - do you want me to make further changes ? Perhaps squashing commits ?

Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there. A bit more detail on the JSDocs and default case handling.

tools/rum/slicer.js Outdated Show resolved Hide resolved
tools/rum/slicer.js Outdated Show resolved Hide resolved
tools/rum/slicer.js Outdated Show resolved Hide resolved
tools/rum/slicer.js Outdated Show resolved Hide resolved
tools/rum/slicer.js Show resolved Hide resolved
tools/rum/cruncher.js Outdated Show resolved Hide resolved
tools/rum/cruncher.js Outdated Show resolved Hide resolved
tools/rum/cruncher.js Outdated Show resolved Hide resolved
tools/rum/cruncher.js Outdated Show resolved Hide resolved
@akalfas akalfas requested a review from trieloff June 5, 2024 14:58
tools/rum/cruncher.js Outdated Show resolved Hide resolved
tools/rum/slicer.js Outdated Show resolved Hide resolved
* main:
  fix: lazy load facet images
  fix: align select with eye
  chore: lint
  chore: lint
  fix: inherit font in rum form els (input, select)
  fix: use maximum cwv value for cls and lcp
@akalfas akalfas requested a review from trieloff June 7, 2024 06:46
@trieloff trieloff closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants