-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rum-explorer) conversions can be tuned in a headless mode #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in progress.
fd8d33b
to
f19d8a7
Compare
@trieloff - do you want me to make further changes ? Perhaps squashing commits ? |
b3c6640
to
7b893b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there. A bit more detail on the JSDocs and default case handling.
7b893b5
to
281142d
Compare
281142d
to
ae92f17
Compare
* main: fix: lazy load facet images fix: align select with eye chore: lint chore: lint fix: inherit font in rum form els (input, select) fix: use maximum cwv value for cls and lcp
It provides a headless alternative for #523 - will still need some sort of a ux on top.