Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign/qa fix #320

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Redesign/qa fix #320

merged 4 commits into from
Jun 29, 2023

Conversation

snowiewdev
Copy link
Collaborator

@snowiewdev snowiewdev commented Jun 29, 2023 •
edited
Loading

Minor Fixes

  • breadcrumb capitalize category
  • back arrow color update
  • ui fix in doc detail: embed gist font size, temp fix for table styles, mobile overflow fix
  • sidebar arrow animation
  • bug fix on mobile menu transparent area on scroll

Test Urls:
Before: https://website-redesign--helix-website--adobe.hlx.page/docs/sidekick
After: https://redesign-qa-fix--helix-website--adobe.hlx.page/docs/sidekick

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023 •
edited
Loading

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@snowiewdev snowiewdev added the redesign Task related to the website redesign label Jun 29, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Page Scores Audits Google
/docs/sidekick PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Page Scores Audits Google
/docs/sidekick PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Page Scores Audits Google
/docs/sidekick PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Page Scores Audits Google
/docs/sidekick PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nicolerego nicolerego merged commit e8350f5 into website-redesign Jun 29, 2023
3 checks passed
@nicolerego nicolerego deleted the redesign/qa-fix branch June 29, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolerego nicolerego nicolerego approved these changes

Assignees
No one assigned
Labels
redesign Task related to the website redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowiewdev @nicolerego