Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Table Fixes - block name row, alignment info #480

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

janaki-r-bhagwath
Copy link
Collaborator

  • Treat block name row like a regular row instead of header - updated all test mds to reflect same.
  • Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Related Issues

#474 and #475

</div>
</div>
</div>
<div class=="block-with-align">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class=="block-with-align">
<div class="block-with-align">

</div>
</div>
</div>
<div class=="block-with-valign">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class=="block-with-valign">
<div class="block-with-valign">

Copy link

This PR will trigger no release when merged.

- Treat block name row like a regular row instead of header - updated all test mds to reflect same.
- Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Resolves: #474 and #475
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (82b3b83) to head (b5946ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #480   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          788       793    +5     
  Branches         1         1           
=========================================
+ Hits           788       793    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tripodsan tripodsan merged commit 3a742b6 into main May 30, 2024
8 checks passed
@tripodsan tripodsan deleted the table-fixes branch May 30, 2024 14:27
github-actions bot pushed a commit that referenced this pull request May 30, 2024
## [2.8.25](v2.8.24...v2.8.25) (2024-05-30)

### Bug Fixes

* block name row, alignment info ([#480](#480)) ([3a742b6](3a742b6)), closes [#474](#474) [#475](#475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants