Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-align and data-valign information from html should be available in generated md. #475

Open
janaki-r-bhagwath opened this issue May 15, 2024 · 0 comments
Open

data-align and data-valign information from html should be available in generated md. #475

janaki-r-bhagwath opened this issue May 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@janaki-r-bhagwath
Copy link
Collaborator

importing a block that had alignments in the docx are not round-tripable back to markdown, because the alignment information from html is not getting passed to generated md.

data-align and data-valign information from html should be available in generated md.

Context:
We have use cases where we try to diff the docx -> md and html -> md where this creates a discrepancy.
@janaki-r-bhagwath janaki-r-bhagwath added the enhancement New feature or request label May 15, 2024
janaki-r-bhagwath pushed a commit that referenced this issue May 30, 2024
Grid Table Fixes - block name row, alignment info
4ad7d97 
- Treat block name row like a regular row instead of header - updated all test mds to reflect same.
- Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Resolves: #474 and #475
janaki-r-bhagwath pushed a commit that referenced this issue May 30, 2024
Grid Table Fixes - block name row, alignment info
85ea967 
- Treat block name row like a regular row instead of header - updated all test mds to reflect same.
- Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Resolves: #474 and #475
@janaki-r-bhagwath janaki-r-bhagwath mentioned this issue May 30, 2024
Merged
janaki-r-bhagwath pushed a commit that referenced this issue May 30, 2024
Grid Table Fixes - block name row, alignment info
e32a046 
- Treat block name row like a regular row instead of header - updated all test mds to reflect same.
- Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Resolves: #474 and #475
janaki-r-bhagwath pushed a commit that referenced this issue May 30, 2024
Grid Table Fixes - block name row, alignment info
b5946ea 
- Treat block name row like a regular row instead of header - updated all test mds to reflect same.
- Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Resolves: #474 and #475
tripodsan pushed a commit that referenced this issue May 30, 2024
@janaki-r-bhagwath
fix: block name row, alignment info (#480)
3a742b6 
- Treat block name row like a regular row instead of header - updated all test mds to reflect same.
- Extract align and valign info from html and ensure it is present in md. Added tests specific to it.

Resolves: #474 and #475

Co-authored-by: bhagwath <[email protected]>
github-actions bot pushed a commit that referenced this issue May 30, 2024
@semantic-release-bot
chore(release): 2.8.25 [skip ci]
6541302 
## [2.8.25](v2.8.24...v2.8.25) (2024-05-30)

### Bug Fixes

* block name row, alignment info ([#480](#480)) ([3a742b6](3a742b6)), closes [#474](#474) [#475](#475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janaki-r-bhagwath