This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Issues/147 #3
Merged
Issues/147 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trieloff
reviewed
Jun 12, 2018
| path: 'SUMMARY.md' | ||
| }; | ||
|
|
||
| return md2json.main(params).then(info => { |
There was a problem hiding this comment.
@kptdobe I think this is the wrong way to do it – every template script should render only one single resource and never try to go back to the repository.
You can handle this much better though an edge-side include (take a look at the nav.md example in template2lamdba, with better overall performance.
There was a problem hiding this comment.
I've filed adobe/project-helix#171 and #4 for this
There was a problem hiding this comment.
Yes, I agree. Step by step... for now, that's the only way to do it.
trieloff
reviewed
Jun 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.