Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle section breaks when pasted as dashes or from Word #219

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented Sep 25, 2024

Description

Convert triple dashes on a line by itself to a section break. Applies to both pasted text as well as typing '---' and pressing Enter.

Also handle Word-specific section breaks when pasted from Word online or desktop Word.

Test URLs:

Note: This code was previously approved in #210 but then reverted as the regeneration of da-y-wrapper caused issues. These issues have since been resolved separately in #214.

Related Issue

Fixes: #209

Motivation and Context

It preserves section breaks copied & pasted from Word and elsewhere.

How Has This Been Tested?

Tested manually. I intend to add unit tests in a separate commit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Convert triple dashes on a line by itself to a section break. Applies to
both pasted text as well as typing '---' and pressing Enter.

Also handle Word-specific section breaks when pasted from Word online or desktop Word.

Fixes: #209
Copy link

aem-code-sync bot commented Sep 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 25, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert bosschaert merged commit e3091a2 into main Sep 26, 2024
6 checks passed
@bosschaert bosschaert deleted the dashes-2 branch September 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triple dash support
2 participants