Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 Live Preview Icons #103

Merged
merged 1 commit into from
Apr 15, 2024
Merged

#38 Live Preview Icons #103

merged 1 commit into from
Apr 15, 2024

Conversation

chrischrischris
Copy link
Contributor

@chrischrischris chrischrischris commented Apr 10, 2024

Description

Icons were showing as :icon-name: in the preview pane. This converts the icon strings to icon spans for them to render properly in the preview pane (not to be confused with franklin preview where icons are working).

Related Issue

#38

Release notes

Support icons (:my-icon:) in live preview.

Copy link

aem-code-sync bot commented Apr 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@auniverseaway auniverseaway changed the title #38 Make icons work in preview #38 Live Preview Icons Apr 10, 2024
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Another MVP item down.

@auniverseaway auniverseaway merged commit 4f09c58 into main Apr 15, 2024
4 of 5 checks passed
@auniverseaway auniverseaway deleted the ccc-icon-previewq branch April 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants