Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms 9688 checkbox proxy component #1130

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

barshat7
Copy link
Contributor

@barshat7 barshat7 commented Sep 6, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jcr:description="Adaptive Form Check Box (v1) component"
jcr:primaryType="cq:Component"
jcr:title="Check Box"
sling:resourceSuperType="core/fd/components/form/checkbox/v1/checkbox"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barshat7 do we also need to update the core components version in archetype before this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be done once we have the final release for cc

@pankaj-parashar pankaj-parashar merged commit f3936ce into develop Sep 20, 2023
9 checks passed
@pankaj-parashar pankaj-parashar deleted the FORMS-9688_checkbox_proxy_component branch September 20, 2023 05:18
@pankaj-parashar pankaj-parashar added this to the 45 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants