Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CQ-4353443: Add cypress ui tests #1111

Merged
merged 13 commits into from
Aug 21, 2023
Merged

CQ-4353443: Add cypress ui tests #1111

merged 13 commits into from
Aug 21, 2023

Conversation

kronnox
Copy link
Member

@kronnox kronnox commented Jul 19, 2023 •
edited
Loading

The goal of this PR is to have sample Cypress Tests published as part of the Archetype, so that customers which create new projects have them by default.

Related Issue

  • CQ-4353443

How Has This Been Tested?

  • Ran locally.
  • Copied over generated files to CM env and ran pipeline.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kronnox kronnox marked this pull request as ready for review August 2, 2023 09:30
AlexRRR
AlexRRR approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@AlexRRR AlexRRR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested generation + test execution 👍 LGTM

dulvac
dulvac approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@dulvac dulvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bpauli bpauli merged commit dd01179 into adobe:develop Aug 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisswanger bisswanger bisswanger left review comments

@dulvac dulvac dulvac approved these changes

@AlexRRR AlexRRR AlexRRR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kronnox @AlexRRR @dulvac @bisswanger @bpauli