Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor branch, improve UI (two columns) and visibility #21

Merged
merged 8 commits into from
Oct 15, 2023

Conversation

ananya173147
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@samarthshetty09 samarthshetty09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some review comments, rest looks good

<span aria-hidden="true">&times;</span>
</button>

<div class="row" style="margin-top: 25px;">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using rem instead of px, instead of row, col (Table) use flexBox.

Don't add styles in HTML, define a class and move it to stylesheet.css

Copy link
Collaborator

@rishi2019194 rishi2019194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@rishi2019194 rishi2019194 merged commit d1b2c21 into master Oct 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants