Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove namespace dependency #13

Closed
wants to merge 1 commit into from
Closed

Conversation

adinhodovic
Copy link
Owner

To improve usage in non-k8s environments

To improve usage in non-k8s environments
@Ch00k
Copy link
Contributor

Ch00k commented Aug 12, 2024

I just discovered this project while trying to build some dashboards for my Django project running in Docker Compose. Is there anything preventing this PR from getting merged?

@adinhodovic
Copy link
Owner Author

Hey @Ch00k,

Yeah I opened this PR since I thought it was causing issues for docker setups, however it seems to be the time range and scrape interval that needed adjusting in all those issues.

What are you having for issues?

@Ch00k
Copy link
Contributor

Ch00k commented Aug 12, 2024

I am not sure what issues I really had, but when I downloaded the dashboards from grafana.com, all of the panes displayed "No Data". I have since discovered #15 and this PR, and have imported the dashboards from that PR's branch. I do see data now. I will try to re-import the dashboards from grafana.com to see if that indeed was a time range issue.

For completeness sake, this is what my prometheus.yml looks:

scrape_configs:
  - job_name: 'mottle'
    static_configs:
      - targets: ['web:65432']

It does not define the scrape_interval, so the default 15s is in use here.

@adinhodovic
Copy link
Owner Author

I am not sure what issues I really had, but when I downloaded the dashboards from grafana.com, all of the panes displayed "No Data". I have since discovered #15 and this PR, and have imported the dashboards from that PR's branch. I do see data now. I will try to re-import the dashboards from grafana.com to see if that indeed was a time range issue.

For completeness sake, this is what my prometheus.yml looks:

scrape_configs:
  - job_name: 'mottle'
    static_configs:
      - targets: ['web:65432']

It does not define the scrape_interval, so the default 15s is in use here.

Cool, if it seems fixed I'll close this PR to not confuse people. It seems to work fine with docker setups. Did it work?

@Ch00k
Copy link
Contributor

Ch00k commented Aug 17, 2024

Could not get to it earlier, but I just re-imported the dashboards from dashboards_out in the main branch, and I do see data in the panels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants