Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old config files #86

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

rhizoome
Copy link

No description provided.

Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but are those absolutely not needed anymore?

@rhizoome
Copy link
Author

rhizoome commented Mar 14, 2024

LGTM - but are those absolutely not needed anymore?

We can't use them anymore, but I am not sure if we never want to look at any of these files again. I didn't actually convert all of these files, some weren't used. Is it good enough that we can go back using git?

@winged
Copy link
Member

winged commented Mar 14, 2024

LGTM - but are those absolutely not needed anymore?

We can't use them anymore, but I am not sure if we never want to look at any of these files again. I didn't actually convert all of these files, some weren't used. Is it good enough that we can go back using git?

I thought you were maybe going to convert them all in another PR. But if we don't actually need them (or their toml equivalent) anymore, then yeah for sure, delete them

@winged winged merged commit 672af8d into main Mar 14, 2024
1 check passed
@rhizoome rhizoome deleted the jlf/chore-remove-old-config-files branch March 21, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants