feat: import CalledProcessError for users of run_command (no merge, nl)
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhizoome
changed the title
CalledProcessError for users of run_command (no merge)CalledProcessError for users of run_command (no merge)
added 2 commits
March 3, 2024 16:58
chore: fix typing of cmd_args
rhizoome
force-pushed
the
jlf/feat-import-CalledProcessError-for-users-of-run_command
branch
from
0d13e2a
to
3618162
Compare
refactor: update command execution logic to fail hard if a command fails
rhizoome
changed the title
CalledProcessError for users of run_command (no merge)CalledProcessError for users of run_command (no merge, nl)
added 5 commits
March 4, 2024 10:51
refactor: use `run_command` in `Command` (no merge)
…-run_command refactor: replace `check_call` with `run_command` (no-merge)
…with-run_command- refactor: replace `call_output` with `run_command` (no merge, nl)
rhizoome
deleted the
jlf/feat-import-CalledProcessError-for-users-of-run_command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: fix typing of cmd_args
do not merge