chore(lint): linted with ruff

api/manage.py

@@ -10,10 +10,9 @@ def main():
  try:
  from django.core.management import execute_from_command_line
  except ImportError as exc:
+ msg = "Couldn't import Django. Are you sure it's installed and available on your PYTHONPATH environment variable? Did you forget to activate a virtual environment?"
  raise ImportError(
- "Couldn't import Django. Are you sure it's installed and "
- "available on your PYTHONPATH environment variable? Did you "
- "forget to activate a virtual environment?"
+ msg,
  ) from exc
  execute_from_command_line(sys.argv)
 

api/outdated/models.py

@@ -20,6 +20,7 @@ class UniqueBooleanField(models.BooleanField):
  by providing a list of field names as `together` param.
 
  Example:
+ -------
  ```
  >>> class Email(models.Model):
  ... user = models.ForeignKey(User)

api/outdated/oidc_auth/authentication.py

@@ -15,13 +15,12 @@ def verify_claims(self, claims):
 
  for claim in claims_to_verify:
  if claim not in claims:
- raise SuspiciousOperation(f'Couldn\'t find "{claim}" claim')
+ msg = f'Couldn\'t find "{claim}" claim'
+ raise SuspiciousOperation(msg)
 
  def get_or_create_user(self, access_token, *args):
  claims = self.get_userinfo(access_token, *args)
 
  self.verify_claims(claims)
 
- user = OIDCUser(access_token, claims)
-
- return user
+ return OIDCUser(access_token, claims)

api/outdated/oidc_auth/models.py

@@ -17,7 +17,7 @@ def __str__(self):
 
 
 class OIDCUser(BaseUser):
- def __init__(self, token: str, claims: dict):
+ def __init__(self, token: str, claims: dict) -> None:
  super().__init__()
 
  self.claims = claims
@@ -47,3 +47,6 @@ def _get_or_create_user(self):
 
  def __str__(self):
  return f"{self.email} - {self.id}"
+
+
+""

api/outdated/oidc_auth/permissions.py

@@ -2,8 +2,8 @@
 
 
 class IsAuthenticated(BasePermission):
- def has_permission(self, request, view):
+ def has_permission(self, request, _):
  return bool(request.user and request.user.is_authenticated)
 
- def has_object_permission(self, request, view, obj):
+ def has_object_permission(self, request, view, _):
  return self.has_permission(request, view)

api/outdated/oidc_auth/tests/test_authentication.py

@@ -11,7 +11,7 @@
 
 
 @pytest.mark.parametrize(
- "authentication_header,authenticated,error",
+ ("authentication_header", "authenticated", "error"),
  [
  ("", False, False),
  ("Bearer", False, True),
@@ -21,7 +21,14 @@
  ],
 )
 def test_authentication(
- db, rf, authentication_header, authenticated, error, requests_mock, settings, claims
+ db,
+ rf,
+ authentication_header,
+ authenticated,
+ error,
+ requests_mock,
+ settings,
+ claims,
 ):
  assert User.objects.count() == 0
 
@@ -44,7 +51,8 @@ def test_authentication(
 
 
 @pytest.mark.parametrize(
- "modified_claim", ["email", "first_name", "last_name", "username"]
+ "modified_claim",
+ ["email", "first_name", "last_name", "username"],
 )
 def test_authentication_claims_changed(
  db,
@@ -71,7 +79,8 @@ def test_authentication_idp_502(
  settings,
 ):
  requests_mock.get(
- settings.OIDC_OP_USER_ENDPOINT, status_code=status.HTTP_502_BAD_GATEWAY
+ settings.OIDC_OP_USER_ENDPOINT,
+ status_code=status.HTTP_502_BAD_GATEWAY,
  )
 
  request = rf.get("/openid", HTTP_AUTHORIZATION="Bearer Token")

api/outdated/outdated/factories.py

@@ -1,10 +1,12 @@
 import random
-from datetime import date, timedelta
+from datetime import timedelta
 
+from django.utils import timezone
 from factory import Faker, Sequence, SubFactory, Trait, post_generation
 from factory.django import DjangoModelFactory
 
-from ..user.factories import UserFactory
+from outdated.user.factories import UserFactory
+
 from . import models
 
 PROVIDERS = ["PIP", "NPM"]
@@ -31,12 +33,12 @@ class Meta:
 
  class Params:
  undefined = Trait(end_of_life=None)
- outdated = Trait(end_of_life=date.today())
+ outdated = Trait(end_of_life=timezone.datetime.now().date())
  warning = Trait(
- end_of_life=date.today() + timedelta(days=150),
+ end_of_life=timezone.datetime.now().date() + timedelta(days=150),
  )
  up_to_date = Trait(
- end_of_life=date.today() + timedelta(days=365),
+ end_of_life=timezone.datetime.now().date() + timedelta(days=365),
  )
 
 

api/outdated/outdated/management/commands/syncproject.py

@@ -1,7 +1,7 @@
 from django.core.management.base import BaseCommand
 
-from ...models import Project
-from ...synchroniser import Synchroniser
+from outdated.outdated.models import Project
+from outdated.outdated.synchroniser import Synchroniser
 
 
 class Command(BaseCommand):
@@ -10,7 +10,7 @@ class Command(BaseCommand):
  def add_arguments(self, parser):
  parser.add_argument("project_name", type=str)
 
- def handle(self, *args, **options):
+ def handle(self, *_, **options):
  project_name = options["project_name"]
  try:
  project = Project.objects.get(name__iexact=project_name)

api/outdated/outdated/management/commands/syncprojects.py

@@ -1,9 +1,8 @@
 from asyncio import gather
 
 from outdated.commands import AsyncCommand
-
-from ...models import Project
-from ...synchroniser import Synchroniser
+from outdated.outdated.models import Project
+from outdated.outdated.synchroniser import Synchroniser
 
 
 class Command(AsyncCommand):

api/outdated/outdated/models.py

@@ -1,11 +1,11 @@
-from datetime import date, timedelta
+from datetime import timedelta
 
 from django.db import models
 from django.db.models.functions import Lower
+from django.utils import timezone
 
 from outdated.models import UniqueBooleanField, UUIDModel
-
-from ..user.models import User
+from outdated.user.models import User
 
 STATUS_OPTIONS = {
  "outdated": "OUTDATED",
@@ -21,7 +21,7 @@
  "NPM": "https://registry.npmjs.org/%s",
 }
 
-PROVIDER_CHOICES = [(provider, provider) for provider in PROVIDER_OPTIONS.keys()]
+PROVIDER_CHOICES = [(provider, provider) for provider in PROVIDER_OPTIONS]
 
 
 class Dependency(UUIDModel):
@@ -62,9 +62,9 @@ class Meta:
  def status(self):
  if not self.end_of_life:
  return STATUS_OPTIONS["undefined"]
- elif date.today() >= self.end_of_life:
+ if timezone.datetime.now().date() >= self.end_of_life:
  return STATUS_OPTIONS["outdated"]
- elif date.today() + timedelta(days=150) >= self.end_of_life:
+ if timezone.datetime.now().date() + timedelta(days=150) >= self.end_of_life:
  return STATUS_OPTIONS["warning"]
  return STATUS_OPTIONS["up_to_date"]
 
@@ -104,7 +104,7 @@ class Meta:
  fields=["name"],
  condition=models.Q(name__iexact=Lower("name")),
  name="unique_project_name",
- )
+ ),
  ]
 
  @property
@@ -119,7 +119,9 @@ def __str__(self):
 class Maintainer(UUIDModel):
  user = models.ForeignKey(User, on_delete=models.CASCADE)
  project = models.ForeignKey(
- Project, on_delete=models.CASCADE, related_name="maintainers"
+ Project,
+ on_delete=models.CASCADE,
+ related_name="maintainers",
  )
  is_primary = UniqueBooleanField(default=False, together=["project"])
 

api/outdated/outdated/serializers.py

@@ -12,7 +12,7 @@ class Meta:
 class ReleaseVersionSerializer(serializers.ModelSerializer):
  status = serializers.ReadOnlyField()
  included_serializers = {
- "dependency": "outdated.outdated.serializers.DependencySerializer"
+ "dependency": "outdated.outdated.serializers.DependencySerializer",
  }
 
  class Meta:
@@ -22,7 +22,7 @@ class Meta:
 
 class VersionSerializer(serializers.ModelSerializer):
  included_serializers = {
- "release_version": "outdated.outdated.serializers.ReleaseVersionSerializer"
+ "release_version": "outdated.outdated.serializers.ReleaseVersionSerializer",
  }
 
  class Meta:
@@ -43,7 +43,9 @@ class Meta:
 
 class ProjectSerializer(serializers.ModelSerializer):
  maintainers = serializers.ResourceRelatedField(
- many=True, read_only=True, required=False
+ many=True,
+ read_only=True,
+ required=False,
  )
 
  included_serializers = {