feat: rewrite of the Ember frontend #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkm-adfinis
force-pushed
the
update-5
branch
2 times, most recently
from
7912826 to
cbfe2f8
Compare
As discussed this my attempt to overcome the burdens of a legacy application that resisted my attempts to update.
velrest
requested changes
Oct 15, 2020
velrest
requested changes
Oct 15, 2020
There was a problem hiding this comment.
So there are a few things which are issues concerning more than one file (as always open for discussion):
- Format
.hbswith prettier - Notify user if you redirect them out of permissions checks for less confusion
- Please re add acceptance tests since it seems like you completely remove d mirage and all acceptance tests
- Do you not need the
public/assetsanymore?
|
Currently, the project only uses UIkit assets. This will probably change with the design for the login page. Acceptance tests are something I cannot argue against. Most/all other tests can - IMO - be done through unit and integration tests. But I will port Mirage and the acceptance tests from the old version 😃 |
Some proxies remain (for now).
|
It looks like I'm not a project admin on Travis. If you are neither I'll ask around. |
This will provide preset-env out of the box.
This adds the block-indentation rule to the template-lint config and adjusts the tempaltes accordingly.
* Sets a more neutral description. * Corrects legacy email address. * Adds another maintainer.
Tell the user that he doesn't have access before redirecting.
Where not necessary.
As the query param is accessible through the transition.
velrest
approved these changes
Oct 27, 2020
Performance integration leads to an error.
I forgot to remove the timed prefixes in the tests.
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #142
As discussed this my attempt to overcome the burdens of a legacy
application that resisted my attempts to update.