refactor(skeleton): refacto skeleton API #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powerplex
approved these changes
Nov 5, 2024
soykje
force-pushed
the
refacto-skeleton-api
branch
from
bbfdbd2
to
72d9398
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #2503 +/- ##
==========================================
+ Coverage 96.21% 96.23% +0.02%
==========================================
Files 517 520 +3
Lines 4382 4409 +27
Branches 1368 1372 +4
==========================================
+ Hits 4216 4243 +27
Misses 162 162
Partials 4 4 ☔ View full report in Codecov by Sentry. |
acd02
approved these changes
Nov 5, 2024
soykje
force-pushed
the
refacto-skeleton-api
branch
from
72d9398
to
1ac0a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK: SPA-385
Description, Motivation and Context
Following recent discussions we finally decided to leave layout management to consumers.
Types of changes
Screenshots - Animations