Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend dark mode to entire Storybook UI #2492

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat: extend dark mode to entire Storybook UI #2492

merged 1 commit into from
Oct 29, 2024

Conversation

acd02
Copy link
Contributor

@acd02 acd02 commented Oct 25, 2024

Description, Motivation and Context

Currently, we have implemented dark mode support only within individual stories in Storybook.

However, this can create inconsistencies in the user interface, where some parts are in dark mode while others remain in light mode.

We would like to extend the dark mode functionality to cover the entire Storybook UI (the whole page) to provide a consistent user experience.

Types of changes

  • 🛠️ Tool
  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (6712d4c) to head (53ca89d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2492   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         515      515           
  Lines        4377     4377           
  Branches     1409     1409           
=======================================
  Hits         4211     4211           
  Misses        162      162           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acd02 acd02 merged commit 6e52250 into main Oct 29, 2024
9 checks passed
@acd02 acd02 deleted the SPA-359 branch October 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants