Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpNext play_url support #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dagwieers
Copy link
Collaborator

This adds UpNext play_url support and removes the old interface.

The aim is to move this functionality to Up Next so it is easier to
integrate with Up Next and offer the best experience in Up Next.
(Without work-arounds in VRT NU)

This would require play_url support in Up Next.

@dagwieers dagwieers added the enhancement New feature or request label Dec 11, 2019
@dagwieers dagwieers added this to the Future milestone Dec 11, 2019
@dagwieers dagwieers force-pushed the play_url branch 3 times, most recently from 5afdcfd to a92659e Compare December 12, 2019 02:58
@dagwieers dagwieers force-pushed the play_url branch 3 times, most recently from 725d70c to 475e835 Compare March 25, 2020 14:28
@dagwieers
Copy link
Collaborator Author

@michaelarnauts Now I get both Codecov and Sonarcloud to send comments 🙄

@michaelarnauts
Copy link
Contributor

It is beginning. The bots are taking over!

@dagwieers
Copy link
Collaborator Author

dagwieers commented Mar 25, 2020

For SonarCloud we can disable this per repository: https://jira.sonarsource.com/browse/SCCOMM-19

But it is enabled by default :-( And we cannot disable it for the whole organization...

Now I still need to see why codecov is not picking up my codecov.yml, again.

@add-ons add-ons deleted a comment from sonarqubecloud bot Mar 25, 2020
@dagwieers dagwieers force-pushed the play_url branch 4 times, most recently from 9ccad49 to b01a4a2 Compare March 27, 2020 00:15
@dagwieers dagwieers marked this pull request as draft April 9, 2020 00:16
@add-ons add-ons deleted a comment from codecov bot Apr 9, 2020
@michaelarnauts
Copy link
Contributor

Out of curiousity, is there anything blocking on this?

@dagwieers
Copy link
Collaborator Author

@michaelarnauts Because our own handling is much more sophisticated than what is currently implemented in Up Next. But I think we need to re-evaluate Kodi's behaviour so we don't need anything special at all.

@dagwieers
Copy link
Collaborator Author

dagwieers commented Oct 14, 2020

I reevaluated this with the recent changes to Up Next, and it does seem to work well now. You now get a progress circle running on top of the running episode until the new episode is loaded.

It does feel to take a tiny bit longer than before jumping to the next video, but the original implementatie shows a black screen before playback which is not the case here.

@dagwieers dagwieers marked this pull request as ready for review October 14, 2020 22:36
This adds UpNext `play_url` support and removes the old interface.

The aim is to move this functionality to Up Next so it is easier to
integrate with Up Next and offer the best experience in Up Next.
(Without work-arounds in VRT NU)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants