-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UpNext play_url support #632
base: master
Are you sure you want to change the base?
Conversation
5afdcfd
to
a92659e
Compare
725d70c
to
475e835
Compare
@michaelarnauts Now I get both Codecov and Sonarcloud to send comments 🙄 |
It is beginning. The bots are taking over! |
For SonarCloud we can disable this per repository: https://jira.sonarsource.com/browse/SCCOMM-19 But it is enabled by default :-( And we cannot disable it for the whole organization... Now I still need to see why codecov is not picking up my codecov.yml, again. |
9ccad49
to
b01a4a2
Compare
Out of curiousity, is there anything blocking on this? |
@michaelarnauts Because our own handling is much more sophisticated than what is currently implemented in Up Next. But I think we need to re-evaluate Kodi's behaviour so we don't need anything special at all. |
I reevaluated this with the recent changes to Up Next, and it does seem to work well now. You now get a progress circle running on top of the running episode until the new episode is loaded. It does feel to take a tiny bit longer than before jumping to the next video, but the original implementatie shows a black screen before playback which is not the case here. |
This adds UpNext `play_url` support and removes the old interface. The aim is to move this functionality to Up Next so it is easier to integrate with Up Next and offer the best experience in Up Next. (Without work-arounds in VRT NU)
This adds UpNext
play_url
support and removes the old interface.The aim is to move this functionality to Up Next so it is easier to
integrate with Up Next and offer the best experience in Up Next.
(Without work-arounds in VRT NU)
This would require play_url support in Up Next.