Skip to content

Commit

Permalink
Use SonarCloud and Kodi addon-check fixes (#713)
Browse files Browse the repository at this point in the history
This uses the newer options in the proposed SonarCloud pull-request and
reliability fixes in Kodi's addon-checker.
  • Loading branch information
dagwieers authored Mar 27, 2020
1 parent bb7d9e5 commit d5c9692
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 20 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/addon-check.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
name: Kodi
on:
push:
branches:
- master
pull_request:
branches:
- master
- pull_request
- push
jobs:
tests:
name: Addon checker
Expand All @@ -26,7 +22,9 @@ jobs:
run: |
sudo apt-get install libxml2-utils xmlstarlet
python -m pip install --upgrade pip
pip install kodi-addon-checker
# FIXME: Requires changes from xbmc/addon-check#217
#pip install kodi-addon-checker
pip install git+git://github.com/dagwieers/addon-check.git@retry-repo#egg=kodi-addon-checker
- name: Remove unwanted files
run: awk '/export-ignore/ { print $1 }' .gitattributes | xargs rm -rf --
working-directory: ${{ github.repository }}
Expand Down
21 changes: 8 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,15 @@ jobs:
- name: Upload code coverage to CodeCov
uses: codecov/codecov-action@v1
continue-on-error: true
- name: Prepare for SonarCloud
run: |
cat <<EOF >sonar-project.properties
sonar.language=python
sonar.organization=add-ons
sonar.python.coverage.reportPaths=coverage.xml
sonar.projectKey=add-ons_plugin.video.vrt.nu
sonar.pullrequest.provider=GitHub
sonar.sourceEncoding=UTF-8
sonar.sources=resources/lib
sonar.test.exclusions=tests/**
EOF
# FIXME: Requires changes from SonarSource/sonarcloud-github-action#9
- name: Analyze with SonarCloud
uses: sonarsource/sonarcloud-github-action@master
uses: dagwieers/sonarcloud-github-action@more-options
with:
organization: add-ons
projectKey: add-ons_plugin.video.vrt.nu
sources: resources/lib/
tests: tests/
verbose: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down

0 comments on commit d5c9692

Please sign in to comment.