remove nullishCoalesce function and replace with nullish coalesce o…

…perator now that node 12 has reached end of life and node 14+ support the operator
adashrod · Oct 16, 2023 · 5d2c543 · 5d2c543
1 parent f1b88e6
commit 5d2c543
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 32 deletions.
diff --git a/src/lib/rules/logical-expression-complexity.js b/src/lib/rules/logical-expression-complexity.js
@@ -1,5 +1,3 @@
-const { nullishCoalesce } = require("./util/misc-js.js");
-
 /**
  * @fileoverview Rule to flag overly complex logical expressions
  * @author Aaron Rodriguez
@@ -50,10 +48,10 @@ module.exports = {
  },
  create(context) {
  const configuration = context.options[0] || {},
- maxHeight = nullishCoalesce(configuration.maxHeight, 2),
- maxTerms = nullishCoalesce(configuration.maxTerms, 4),
- binaryOperators = nullishCoalesce(configuration.binaryOperators, []),
- includeTernary = nullishCoalesce(configuration.includeTernary, true);
+ maxHeight = configuration.maxHeight ?? 2,
+ maxTerms = configuration.maxTerms ?? 4,
+ binaryOperators = configuration.binaryOperators ?? [],
+ includeTernary = configuration.includeTernary ?? true;
 
  const heightObserved = new Set();
  const countObserved = new Set();

diff --git a/src/lib/rules/ordered-import-members.js b/src/lib/rules/ordered-import-members.js
@@ -1,5 +1,4 @@
 const { findPunctuatorAfter, findPunctuatorBetween } = require("./util/ast.js");
-const { nullishCoalesce } = require("./util/misc-js.js");
 
 /**
  * @fileoverview Rule to enforce ordering of import members by name
@@ -40,8 +39,8 @@ module.exports = {
  },
  create(context) {
  const configuration = context.options[0] || {},
- ignoreCase = nullishCoalesce(configuration.ignoreCase, false),
- sortSpecifiersWithComments = nullishCoalesce(configuration.sortSpecifiersWithComments, false),
+ ignoreCase = configuration.ignoreCase ?? false,
+ sortSpecifiersWithComments = configuration.sortSpecifiersWithComments ?? false,
  sourceCode = context.getSourceCode();
 
  /**

diff --git a/src/lib/rules/ordered-imports-by-path.js b/src/lib/rules/ordered-imports-by-path.js
@@ -1,5 +1,3 @@
-const { nullishCoalesce } = require("./util/misc-js.js");
-
 /**
  * @fileoverview Rule to enforce ordering of imports by path
  * @author Aaron Rodriguez
@@ -52,10 +50,10 @@ module.exports = {
  },
  create(context) {
  const configuration = context.options[0] || {},
- ignoreCase = nullishCoalesce(configuration.ignoreCase, false),
- allowSeparateGroups = nullishCoalesce(configuration.allowSeparateGroups, true),
- sortTypeImportsFirst = nullishCoalesce(configuration.sortTypeImportsFirst, true),
- sortSideEffectsFirst = nullishCoalesce(configuration.sortSideEffectsFirst, false),
+ ignoreCase = configuration.ignoreCase ?? false,
+ allowSeparateGroups = configuration.allowSeparateGroups ?? true,
+ sortTypeImportsFirst = configuration.sortTypeImportsFirst ?? true,
+ sortSideEffectsFirst = configuration.sortSideEffectsFirst ?? false,
  sourceCode = context.getSourceCode();
 
  /**

diff --git a/src/lib/rules/strict-camel-case.js b/src/lib/rules/strict-camel-case.js
@@ -1,4 +1,3 @@
-const { nullishCoalesce } = require("./util/misc-js.js");
 const { objectToString } = require("./util/serialization.js");
 
 /**
@@ -64,11 +63,11 @@ module.exports = {
 
  create(context) {
  const options = context.options[0] || {},
- ignoreProperties = nullishCoalesce(options.ignoreProperties, false),
- ignoreImports = nullishCoalesce(options.ignoreImports, false),
+ ignoreProperties = options.ignoreProperties ?? false,
+ ignoreImports = options.ignoreImports ?? false,
  ignoredIdentifiers = options.ignoredIdentifiers || [],
  allowOneCharWords = options.allowOneCharWords || "never",
- ignoreSingleWords = nullishCoalesce(options.ignoreSingleWords, false);
+ ignoreSingleWords = options.ignoreSingleWords ?? false;
 
  const LOG_RULE_PREFIX = "eslint-plugin-sequence/strict-camel-case ";
  const LEVELS = ["OFF", "FATAL", "ERROR", "WARN", "INFO", "DEBUG", "TRACE"];

diff --git a/src/lib/rules/util/misc-js.js b/src/lib/rules/util/misc-js.js