Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Test harness html files now load correct resources (fixes #122) #123

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix: Test harness html files now load correct resources (fixes #122) #123

merged 1 commit into from
Nov 29, 2023

Conversation

k-jensen
Copy link
Contributor

@k-jensen k-jensen commented Nov 6, 2023

Fixes #122

Fix

Updated the html markup for the test harness files.

  • Removed legacy dom elements used for accessibility
  • Links to adapt.css and not the non-existant adapt/css/adapt.css
  • Removed references to IE11, yay

(Copy/pasted https://github.com/adaptlearning/adapt-contrib-core/blob/master/required/index.html then added back in the xapi test scripts)

Testing

  1. Build an adapt course with the adapt-contrib-xapi extension enabled
  2. Serve the course grunt server
  3. Load one of the test html files e.g. https://localhost:9001/xapi_adl_test_harness.html

@k-jensen
Fix: Test harness html files now load correct resources
e2411dd 
- Remove legacy dom elements used for accessibility
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 0f6c91e into adaptlearning:master Nov 29, 2023
1 check failed
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@semantic-release-bot
Chore(release): 1.1.6 [skip ci]
154473d 
## [1.1.6](v1.1.5...v1.1.6) (2023-11-29)

### Fix

* Test harness html files now load correct resources (#123) ([0f6c91e](0f6c91e)), closes [#123](#123)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.1.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@StuartNicholls StuartNicholls StuartNicholls approved these changes

Assignees

@k-jensen k-jensen

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated references in test harness html files
4 participants
@k-jensen @StuartNicholls @oliverfoster @cahirodoherty-learningpool