Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add text-transform variables (fixes #479) #518

Merged
merged 2 commits into from
May 22, 2024
Merged

New: Add text-transform variables (fixes #479) #518

merged 2 commits into from
May 22, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 20, 2024

Fixes #479

New

  • Add text transform variables for titles, buttons, and instruction text.
    • The main purpose is to assist theme developers who are working with rigid client branding requirements (e.g. all buttons must be uppercase).
    • Body was intentionally left out to discourage poor readability of large blocks of text.
    • Schemas have not been updated, but should they be?

Testing

Update new text transform variables and ensure they are reflected in the theme. Examples:

@menu-item-title-text-transform: uppercase
@page-title-text-transform: capitalize

@swashbuck swashbuck self-assigned this May 20, 2024
less/_defaults/_font-config.less Outdated Show resolved Hide resolved
less/_defaults/_font-config.less Show resolved Hide resolved
@kirsty-hames
Copy link
Contributor

  • Schemas have not been updated, but should they be?

I'm in favour of keeping the Schemas simple. I don't think we need to expose every variable in the AAT and these can be added at a later date if needed.

Useful addition thanks @swashbuck.

@swashbuck swashbuck requested a review from kirsty-hames May 21, 2024 14:04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 1d963a6 into master May 22, 2024
@swashbuck swashbuck deleted the issue/479 branch May 22, 2024 13:41
Copy link

🎉 This PR is included in version 9.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text-transform variables
4 participants