Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Schema Corrections (fixes: issue/5) #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Schema Corrections (fixes: issue/5) #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
876684f
Update properties.schema
joe-replin Nov 14, 2024
4075edd
Update course.schema.json
joe-replin Nov 14, 2024
7ce0b48
Update properties.schema
joe-replin Nov 14, 2024
dc1aa1f
Fixes for v1 schemas
joe-allen-89 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 34 additions & 28 deletions properties.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true
"translatable": true,
"help": "Text that appears on the button."
}
}
}
Expand Down Expand Up @@ -307,31 +308,32 @@
"inputType": "Checkbox",
"validators": [],
"help": "Determines whether the notification can be cancelled/closed."
}
}
},
"_closeCoursePrompt": {
"type": "object",
"required": false,
"title": "Close course prompt",
"properties": {
"_isEnabled": {
"type": "boolean",
"required": false,
"default": true,
"title": "Enable close course prompt?",
"inputType": "Checkbox",
"validators": [],
"help": "Determines whether a button prompt to close the course window (only possible if the course was launched in a popup window) is included."
},
"_closeErrorOnSuccess": {
"type": "string",
"_closePrompt": {
"type": "object",
"required": false,
"default": "OK",
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true
"title": "Close notification prompt",
"properties": {
"_isEnabled": {
"type": "boolean",
"required": false,
"default": true,
"title": "Enable close notification button?",
"inputType": "Checkbox",
"validators": [],
"help": "Determines whether a button prompt to close the notification is included."
},
"label": {
"type": "string",
"required": false,
"default": "OK",
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true,
"help": "Text that appears on the button."
}
}
}
}
}
Expand Down Expand Up @@ -367,7 +369,8 @@
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true
"translatable": true,
"help": "Text that appears on the button."
}
}
},
Expand All @@ -392,7 +395,8 @@
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true
"translatable": true,
"help": "Text that appears on the button."
}
}
}
Expand Down Expand Up @@ -469,7 +473,8 @@
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true
"translatable": true,
"help": "Text that appears on the button."
}
}
}
Expand Down Expand Up @@ -546,7 +551,8 @@
"title": "Button label",
"inputType": "Text",
"validators": [],
"translatable": true
"translatable": true,
"help": "Text that appears on the button."
}
}
}
Expand Down
185 changes: 101 additions & 84 deletions schema/course.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,95 +134,112 @@
}
},
"_intermediate": {
"_classes": {
"type": "string",
"title": "Custom classes",
"description": "CSS class name to be applied to the popup. The class must be predefined in one of the LESS files. Separate multiple classes with a space."
},
"title": {
"type": "string",
"title": "Title",
"description": "The text used as the popup title.",
"default": "Connection error"
},
"body": {
"type": "string",
"title": "Body",
"description": "The text used to inform/instruct users about the error.",
"default": "It looks like we still weren’t able to establish a connection. Please check your connections and select <strong>Retry</strong>.<br><br>If the problem persists, please close the course and relaunch the activity."
},
"_isCancellable": {
"type": "boolean",
"title": "Is able to be cancelled?",
"description": "Determines whether the notification can be cancelled/closed.",
"default": false
"type": "object",
"title": "Intermediate",
"default": {},
"properties": {
"_classes": {
"type": "string",
"title": "Custom classes",
"description": "CSS class name to be applied to the popup. The class must be predefined in one of the LESS files. Separate multiple classes with a space."
},
"title": {
"type": "string",
"title": "Title",
"description": "The text used as the popup title.",
"default": "Connection error"
},
"body": {
"type": "string",
"title": "Body",
"description": "The text used to inform/instruct users about the error.",
"default": "It looks like we still weren’t able to establish a connection. Please check your connections and select <strong>Retry</strong>.<br><br>If the problem persists, please close the course and relaunch the activity."
},
"_isCancellable": {
"type": "boolean",
"title": "Is able to be cancelled?",
"description": "Determines whether the notification can be cancelled/closed.",
"default": false
}
}
},
"_final": {
"_classes": {
"type": "string",
"title": "Custom classes",
"description": "CSS class name to be applied to the popup. The class must be predefined in one of the LESS files. Separate multiple classes with a space."
},
"title": {
"type": "string",
"title": "Title",
"description": "The text used as the popup title.",
"default": "Connection Failure"
},
"body": {
"type": "string",
"title": "Body",
"description": "The text used to inform/instruct users about the error.",
"default": "Unfortunately, we were unable to re-establish a connection. Your recent progress will not be saved.<br><br>Please close the course and try again at a later time."
},
"_isCancellable": {
"type": "boolean",
"title": "Is able to be cancelled?",
"description": "Determines whether the notification can be cancelled/closed.",
"default": false
"type": "object",
"title": "Final",
"default": {},
"properties": {
"_classes": {
"type": "string",
"title": "Custom classes",
"description": "CSS class name to be applied to the popup. The class must be predefined in one of the LESS files. Separate multiple classes with a space."
},
"title": {
"type": "string",
"title": "Title",
"description": "The text used as the popup title.",
"default": "Connection Failure"
},
"body": {
"type": "string",
"title": "Body",
"description": "The text used to inform/instruct users about the error.",
"default": "Unfortunately, we were unable to re-establish a connection. Your recent progress will not be saved.<br><br>Please close the course and try again at a later time."
},
"_isCancellable": {
"type": "boolean",
"title": "Is able to be cancelled?",
"description": "Determines whether the notification can be cancelled/closed.",
"default": false
}
}
},
"_success": {
"_classes": {
"type": "string",
"title": "Custom classes",
"description": "CSS class name to be applied to the popup. The class must be predefined in one of the LESS files. Separate multiple classes with a space."
},
"title": {
"type": "string",
"title": "Title",
"description": "The text used as the popup title.",
"default": "Connection Success"
},
"body": {
"type": "string",
"title": "Body",
"description": "The text used to inform/instruct users about the error.",
"default": "Your connection was re-established, and your progress has been saved. Select <strong>OK</strong> to continue."
},
"_isCancellable": {
"type": "boolean",
"title": "Is able to be cancelled?",
"description": "Determines whether the notification can be cancelled/closed.",
"default": false
},
"_closeCoursePrompt": {
"type": "object",
"title": "Close course prompt",
"default": {},
"type": "object",
"title": "Success",
"default": {},
"properties": {
"_classes": {
"type": "string",
"title": "Custom classes",
"description": "CSS class name to be applied to the popup. The class must be predefined in one of the LESS files. Separate multiple classes with a space."
},
"title": {
"type": "string",
"title": "Title",
"description": "The text used as the popup title.",
"default": "Connection Success"
},
"body": {
"type": "string",
"title": "Body",
"description": "The text used to inform/instruct users about the error.",
"default": "Your connection was re-established, and your progress has been saved. Select <strong>OK</strong> to continue."
},
"_isCancellable": {
"type": "boolean",
"title": "Is able to be cancelled?",
"description": "Determines whether the notification can be cancelled/closed.",
"default": false
},
"properties": {
"_isEnabled": {
"type": "boolean",
"title": "Enable close course prompt?",
"description": "Determines whether a button prompt to close the course window (only possible if the course was launched in a popup window) is included.",
"default": true
},
"_closeErrorOnSuccess": {
"type": "string",
"title": "Button label",
"description": "",
"default": "OK"
"_closePrompt": {
"type": "object",
"title": "Close notification prompt",
"default": {},
"properties": {
"_isEnabled": {
"type": "boolean",
"title": "Enable close notification button?",
"description": "Determines whether a button prompt to close the notification is included.",
"default": false
},
"label": {
"type": "string",
"title": "Button label",
"description": "Text that appears on the button.",
"default": "Close"
}
}
}
}
}
Expand All @@ -249,7 +266,7 @@
"label": {
"type": "string",
"title": "Button label",
"description": "",
"description": "Text that appears on the button.",
"default": "Retry"
}
}
Expand All @@ -268,7 +285,7 @@
"label": {
"type": "string",
"title": "Button label",
"description": "",
"description": "Text that appears on the button.",
"default": "Close"
}
}
Expand Down