Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Schema Corrections (fixes: issue/5) #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Schema Corrections (fixes: issue/5) #6

wants to merge 4 commits into from

Conversation

joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Nov 14, 2024 •
edited
Loading

Fix

  • Fixes Schema Issue #5
  • Adds help/description text to all button label fields
  • Fixes case where OK button prompt was not appearing for a successful connection test within legacy AAT
  • Adjusts UI text for a successful connection notification

Testing

  1. Install to a legacy AAT instance
  2. Preview a build with this installed
  3. Sever your internet connection to trigger a connection error notification (do not retry test)
  4. Reconnect your internet connection
  5. Retry the connection test
  6. Confirm that an button prompt with label 'OK' appears to close the notification for you.

@joe-replin joe-replin added the bug Something isn't working label Nov 14, 2024
@joe-replin joe-replin self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

Assignees

@joe-replin joe-replin

Labels
bug Something isn't working
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema Issue
3 participants
@joe-replin @lemmyadams @joe-allen-89