Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add pagehide event (Fixes #314) #315

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix: Add pagehide event (Fixes #314) #315

merged 1 commit into from
Apr 22, 2024

Conversation

canstudios-nicolaw
Copy link

Fixes #314

Fix

Added the pagehide event next to the unload event with the same behaviour so that end-users won't notice when Google Chrome stops supporting unload. This is the same fix as was applied in the latest version of Spoor https://github.com/adaptlearning/adapt-contrib-spoor/pull/298/files.

Testing

To test this I tried removing the unload events entirely and switching to pagehide events. I created and published a course and I was able to see that my progress was saved if I closed the window part-way through.

Note

I'm not sure if there is a process for updating an older version of a plugin like this. I created a release-3.3 branch from the v3.3.2 tag. I have made a pull request to add this fix to the release-3.3 branch and I propose we tag v3.3.3 from the release-3.3 branch. I'm open to other suggestions if this isn't the way this is normally done in Adapt.

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Copy link
Member

@canstudios-nicolaw perfect invention of process. I suggest deleting the release branch after doing a manual version release (only the master branch is covered by the automated release process).

Then we can just follow this process any time we need to do similar again, with no leftovers.

@joe-allen-89 joe-allen-89 merged commit a1618bb into release-3.3 Apr 22, 2024
@joe-allen-89 joe-allen-89 deleted the fix/314 branch April 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants