Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding a pagehide listener to cover bases when unload becomes deprecated #298

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: Adding a pagehide listener to cover bases when unload becomes deprecated #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/adapt-stateful-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export default class StatefulSession extends Backbone.Controller {
if (shouldCommitOnVisibilityChange) {
document.addEventListener('visibilitychange', this.onVisibilityChange);
}
$(window).on('beforeunload unload', this.endSession);
$(window).on('beforeunload unload pagehide', this.endSession);
}

async saveSessionState() {
Expand Down Expand Up @@ -261,7 +261,7 @@ export default class StatefulSession extends Backbone.Controller {
}

removeEventListeners() {
$(window).off('beforeunload unload', this.endSession);
$(window).off('beforeunload unload pagehide', this.endSession);
document.removeEventListener('visibilitychange', this.onVisibilityChange);
this.stopListening();
}
Expand Down
2 changes: 1 addition & 1 deletion required/log_output.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
</script>
</head>

<body onload="onLoad();" onunload="onUnload();">
<body onload="onLoad();" onunload="onUnload();" onpagehide="onUnload();">
<div id="logDiv"></div>
</body>

Expand Down
Loading