issue/236 Filter _isTrackable === false before save/restore (#237)

adaptlearning · Jun 27, 2022 · d08b01e · d08b01e
1 parent 8fb4925
commit d08b01e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/js/serializers/ComponentSerializer.js b/js/serializers/ComponentSerializer.js
@@ -23,9 +23,10 @@ export default class ComponentSerializer extends Backbone.Controller {
         return;
       }
       const isContainer = model.hasManagedChildren;
-      const components = isContainer ?
+      let components = isContainer ?
         model.findDescendantModels('component') :
         [model];
+      components = components.filter(component => component.get('_isTrackable') !== false);
       components.forEach((component, index) => {
         if (component.get('_isTrackable') === false) {
           return;
@@ -121,9 +122,10 @@ export default class ComponentSerializer extends Backbone.Controller {
         return;
       }
       const isContainer = model.hasManagedChildren;
-      const components = isContainer ?
+      let components = isContainer ?
         model.findDescendantModels('component') :
         [model];
+      components = components.filter(component => component.get('_isTrackable') !== false);
       const component = components[index];
       if (!component) {
         logging.warn(`SPOOR could not restore tracking id: ${trackingId}, index: ${index}`);