Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: updated collection on _isVisible changes (fixes (#239). #240

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix: updated collection on _isVisible changes (fixes (#239). #240

merged 1 commit into from
Nov 29, 2024

Conversation

danielghost
Copy link
Contributor

Fixes #239.

Fix

  • updated collection on _isVisible changes to reflect appropriate states.

@danielghost danielghost self-assigned this Nov 25, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 3d2bc40 into master Nov 29, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/239 branch November 29, 2024 14:15
github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
@semantic-release-bot
Chore(release): 8.0.4 [skip ci]
b966440 
## [8.0.4](v8.0.3...v8.0.4) (2024-11-29)

### Fix

* updated collection on `_isVisible` changes (fixes #239). (#240) ([3d2bc40](3d2bc40)), closes [#239](#239) [#240](#240)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 8.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@ethan-lp ethan-lp Awaiting requested review from ethan-lp

@lemmyadams lemmyadams Awaiting requested review from lemmyadams

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't respond to _isVisible changes
4 participants
@danielghost @oliverfoster @cahirodoherty-learningpool @joe-allen-89