Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Content object progress calculations (fixes #233) #234

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix: Content object progress calculations (fixes #233) #234

merged 1 commit into from
Jun 27, 2024

Conversation

oliverfoster
Copy link
Member

fixes #233

Fix

  • Defer to calculatePercentageComplete for content objects always

@oliverfoster oliverfoster self-assigned this Jun 24, 2024
guywillis
guywillis approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 553b37a into master Jun 27, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/233 branch June 27, 2024 11:41
github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
@semantic-release-bot
Chore(release): 8.0.2 [skip ci]
9c6ec15 
## [8.0.2](v8.0.1...v8.0.2) (2024-06-27)

### Fix

* Content object progress calculations (fixes #233) (#234) ([553b37a](553b37a)), closes [#233](#233) [#234](#234)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 8.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content object completion miscalculation
4 participants
@oliverfoster @guywillis @cahirodoherty-learningpool @lemmyadams