Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added progressive ItemsComponentModel bars #221

Merged
merged 3 commits into from
May 30, 2024
Merged

New: Added progressive ItemsComponentModel bars #221

merged 3 commits into from
May 30, 2024

Conversation

oliverfoster
Copy link
Member

fixes #220

Fix

  • Allow bars to update when items are visited on presentation components with items

@oliverfoster oliverfoster self-assigned this May 17, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster mentioned this pull request May 24, 2024
Open
kirsty-hames
kirsty-hames reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition thanks @oliverfoster. I just have an observation regarding the Narrative component. Narrative is the only core presentation component that doesn't require an interaction for items to mark as complete. This means the first item is always complete even before the component is in view.

swashbuck
swashbuck approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck requested a review from kirsty-hames May 30, 2024 16:11
@swashbuck swashbuck merged commit 3e193cc into master May 30, 2024
@swashbuck swashbuck deleted the issue/220 branch May 30, 2024 16:33
github-actions bot pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
Chore(release): 7.7.0 [skip ci]
a0941e0 
# [7.7.0](v7.6.3...v7.7.0) (2024-05-30)

### New

* Added progressive ItemsComponentModel bars (#221) ([3e193cc](3e193cc)), closes [#221](#221)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced May 30, 2024
Closed
Closed
@kirsty-hames kirsty-hames mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use progressive bars for ItemsComponentModel components
4 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool