Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: add model type selector to drawer item button (fixes #185) #216

Merged
merged 1 commit into from
May 3, 2024
Merged

New: add model type selector to drawer item button (fixes #185) #216

merged 1 commit into from
May 3, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #185

New

Model _type selector added to .pagelevelprogress__item-btn. This allows for more flexibility when styling nested PLP drawer items.

Selectors include:

Course/Main menu: .is-course-indicator
Page: .is-page-indicator
Sub menu: .is-menu-indicator
Component: .is-component-indicator

@kirsty-hames kirsty-hames self-assigned this Apr 29, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 6b74cbb into master May 3, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/185 branch May 3, 2024 14:02
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@semantic-release-bot
Chore(release): 7.6.0 [skip ci]
7b266ad 
# [7.6.0](v7.5.1...v7.6.0) (2024-05-03)

### Chore

* e2e tests on page level progress extension (Issue/207) (#214) ([3d7c2d0](3d7c2d0)), closes [#214](#214)

### New

* Added type selector to drawer item button (#216) ([6b74cbb](6b74cbb)), closes [#216](#216)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 7.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce new classes for _showAtCourseLevel: true
4 participants
@kirsty-hames @oliverfoster @guywillis @cahirodoherty-learningpool