Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't respond to _isVisible changes #239

Closed
danielghost opened this issue Nov 25, 2024 · 1 comment · Fixed by #240
Closed

Doesn't respond to _isVisible changes #239

danielghost opened this issue Nov 25, 2024 · 1 comment · Fixed by #240
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

Despite the PageLevelProgressItem template handling _isVisible, the items collection isn't updated accordingly when this changes, which can result in items being diabled/enabled inappropriately.
@danielghost danielghost self-assigned this Nov 25, 2024
danielghost added a commit that referenced this issue Nov 25, 2024
@danielghost
Fix: updated collection on _isVisible changes (fixes (#239).
6522c95
@danielghost danielghost moved this from New to Assigned in adapt_framework: The TODO Board Nov 25, 2024
@danielghost danielghost mentioned this issue Nov 25, 2024
Merged
@danielghost danielghost moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Nov 29, 2024
github-actions bot pushed a commit that referenced this issue Nov 29, 2024
@semantic-release-bot
Chore(release): 8.0.4 [skip ci]
b966440 
## [8.0.4](v8.0.3...v8.0.4) (2024-11-29)

### Fix

* updated collection on `_isVisible` changes (fixes #239). (#240) ([3d2bc40](3d2bc40)), closes [#239](#239) [#240](#240)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 8.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@danielghost