-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: completion icon added to transcript button (fixes #290) #291
Conversation
- button/icon styled for consistency with nav button text label/icon - less styles structured in DOM order (skip to transcript btn, transcript btn, transcript body)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Not included in PR
Do you think we should display a plus icon for the inline transcript button to convey the button toggles/expands to reveal content? This would be consistent with the Accordion item button however I'm not wedded to this if people think it's unnecessary.
I think it would make sense for a plus icon to be present especially as we have similar behaviour in the accordion.
Yes to + buttons for expand/collapse generally, maybe not for external transcript? Perhaps? Dunno. |
🎉 This PR is included in version 6.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Agreed. The external transcript button doesn't expand so there is no need for a + icon. New issue raised to display plus icon for inline transcript button - #292. |
Fixes #290
New
Update
.nav__btn
text label/iconNot included in PR
Do you think we should display a plus icon for the inline transcript button to convey the button toggles/expands to reveal content? This would be consistent with the Accordion item button however I'm not wedded to this if people think it's unnecessary. See example below.