Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove isOptional checks preventing optional questions from treated as always being correct (Fixes #54) #55

Merged
merged 2 commits into from
May 14, 2024

Conversation

zubairslamdien
Copy link
Contributor

Fixes #54

Fix

  • isOptional checks removed

@zubairslamdien zubairslamdien added the bug Something isn't working label Apr 30, 2024
@zubairslamdien zubairslamdien self-assigned this Apr 30, 2024
@zubairslamdien zubairslamdien linked an issue Apr 30, 2024 that may be closed by this pull request
@oliverfoster
Copy link
Member

Could you also rework these lines please?

>**\_correct** (string): When the mandatory questions contained are all correct and complete, this is the id of the next content block.
>**\_partlyCorrect** (string): When the mandatory questions contained are partly correct and complete, this is the id of the next content block.
>**\_incorrect** (string): When the mandatory questions contained are all incorrect and complete, this is the id of the next content block.
>**\_hasAttemptBands** (boolean): If set to `true`, turns on the **\_attemptBands** behaviour, allowing branching to happen across both attempts and correctness.
>**\_useQuestionAttempts** (boolean): If set to `true`, **\_hasAttemptBands** will branch according to the previous completed attempts at this question.
>**\_attemptBands** (object array): Multiple items may be created. Each item represents the branching options for the appropriate range of attempts. **\_attemptBands** contains values for **\_attempts**, **\_correct**, **\_partlyCorrect** and **\_incorrect**.
>>**\_attempts** (number): This numeric value represents the start of the range. The range continues to the next highest **\_attempts** of another band.
>>**\_correct** (string): When the mandatory questions contained are all correct and complete, this is the id of the next content block.
>>**\_partlyCorrect** (string): When the mandatory questions contained are partly correct and complete, this is the id of the next content block.
>>**\_incorrect** (string): When the mandatory questions contained are all incorrect and complete, this is the id of the next content block.

As it checks all questions, not just the mandatory ones.

@StuartNicholls
Copy link

Good spot!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit f837ac2 into master May 14, 2024
@oliverfoster oliverfoster deleted the issue/54 branch May 14, 2024 11:20
@oliverfoster oliverfoster changed the title Remove isOptional checks preventing optional questions from treated as always being correct (Fixes #54) Fix: Remove isOptional checks preventing optional questions from treated as always being correct (Fixes #54) May 14, 2024
Copy link

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next ID Correctness is overridden by optional questions
4 participants