-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Added branching by attempt and correctness #50
Conversation
@oliverfoster In the README.md, will you remove the version number and add |
Co-authored-by: Cahir O'Doherty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and no issues for me.
@oliverfoster Can you confirm that this correctly describes how branching works? If so, I can add it to the README.md.
I'm finding that not including a |
@oliverfoster Is there a need to include For example, if a question's number of attempts are set to 10, a branched block would never be shown for an incorrect answer on the 3rd attempt since the question isn't complete yet. It would always have to show the "incorrect" block after the 10th attempt. Therefore, there's no reason to specify what happens when the user answers incorrectly on the 3rd or 5th or 7th attempt. Also, I'm running into some issues in general (could be my JSON configuration). I will DM you a zip of my testing course. |
Where and how did you test this? |
Correct, thanks. |
The block may have two questions, their correctness combines to make block correctness. So it's a little less straightforward than it seems. It must be article+block branching, not block+component, as we can have unlimited blocks in each article, whereas there are limited components per block, in the AAT. Blocks must therefore combine their components' attempts and correctnesses. If the block only had one question then your use-case stands - partlyCorrect and incorrect would not be needed until the final attempt, all previous attempts would only complete on correct responses. So while it would be unusual to need to specify partlyCorrect and incorrect, those are valid use-cases nonetheless, when we consider the two components per block conundrum. It should be fixed now, but you will need adaptlearning/adapt-contrib-trickle#204 for your use-case, with branching in the last article on a page and trickle enabled in it. |
Locally. I just set branching for an MCQ with two correct answers with trickle and added 2 attempts as a band, but I'll test more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Would it be correct to state that this new feature gives us attempt-based-branching rather than attempt-based-feedback? The latter being different question feedback depending on which attempt at the question you are on. |
The only thing that through me off a little was having to set
I see you have put a check in for this though. Just missed at first as it fails 'silently'. Couldn't find any issues however |
Fails silently by posting an error to the console:
|
Yep, all good, I did see that |
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes #49
New
_hasAttemptBands
and_attemptBands
, similar toassessmentResults._bands
, such that branching can occur according to both the block attempt number ranges and block correctness states_useQuestionAttempts
to allow historic completions of a question to determine the attempt branching. Loops can be made across the same question and branch according to the attempt.See example.json