Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessment Banks with Trickle Not Unlocking Next Article #192

Closed
marissa-champions opened this issue Feb 27, 2024 · 4 comments · Fixed by #193 or adaptlearning/adapt-contrib-trickle#213
Closed

Assessment Banks with Trickle Not Unlocking Next Article #192

marissa-champions opened this issue Feb 27, 2024 · 4 comments · Fixed by #193 or adaptlearning/adapt-contrib-trickle#213
Assignees
@oliverfoster
Labels
bug released

Comments

@marissa-champions
Copy link

Subject of the issue/enhancement/features

Assessment with banks and trickle enabled does not unlock next section after assessment completion.

Your environment

  • framework 5.34.0/trickle 7.1.1/assessment 5.1.10/vanilla
  • chrome
  • macOS

Steps to reproduce

Create a course with an assessment and banks and trickle enabled.
Create an article below it.
Complete assessment.
Next article does not unlock.
Returning to menu and then returning to the page does show trickled content however.

Expected behaviour

The second article should untrickle and unlock after the assessment is completed.

Actual behaviour

The article does not unlock.

Screenshots (if you can)

chrome-capture-2024-2-27
oliverfoster added a commit that referenced this issue Feb 27, 2024
@oliverfoster
Fix: Bank blocks only, restore other children (fixes #192)
bb11443
This was referenced Feb 27, 2024
Merged
Merged
@oliverfoster
Copy link
Member

oliverfoster commented Feb 27, 2024 •
edited
Loading

Can you try the two prs list above please?

Replication instructions:

  • Clone vanilla course
  • Change trickle on the assessment article by adding "_onChildren": true,

@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Feb 27, 2024
@marissa-champions
Copy link
Author

This fixes it for me! Thank you!

@oliverfoster
Copy link
Member

Could you approve both please?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

oliverfoster added a commit that referenced this issue Mar 5, 2024
@oliverfoster
Fix: Bank blocks only, restore other children (fixes #192) (#193)
d85f4f7
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 5, 2024
github-actions bot pushed a commit that referenced this issue Mar 5, 2024
@semantic-release-bot
Chore(release): 5.1.11 [skip ci]
eb44d70 
## [5.1.11](v5.1.10...v5.1.11) (2024-03-05)

### Fix

* Bank blocks only, restore other children (fixes #192) (#193) ([d85f4f7](d85f4f7)), closes [#192](#192) [#193](#193)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This issue has been resolved in version 5.1.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
2 participants
@oliverfoster @marissa-champions