Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UTC timezone #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gildorwang
Copy link

Sometimes I need to deal with UTC dates so I updated a little bit:

  1. Add timezone configuration. Accepted values: null or UTC
  2. Add timezone parameter for angular date filter to show date in UTC timezone
  3. Change date format to ISO 8601 format so that date string will be parsed as UTC timezone (only when the timezone configuration is set to UTC)

@gildorwang
Copy link
Author

This should address #74.

@lukebyrne
Copy link

Whats the status of this merge request? I need the same functionality. @adamalbrecht I see that you are doing a rewrite, does this mean all PR's are being ignored for the time being?

@adamalbrecht
Copy link
Owner

@lukebyrne Not necessarily ignoring - I'm just evaluating each one individually to see whether it's worth it at the moment.

In the rewrite, my intention is to make it more focused and modular so that dealing with issues like time zones and date formats is done outside of the library. Otherwise there are just too many edge cases to worry about.

@lukebyrne
Copy link

Cheers, I ended up just using the angularJS inbuilt stuff you had to get the UTC offset I needed for the time being. Thanks for an awesome plugin.

@gildorwang
Copy link
Author

I have coded the support for UTC timezone in my fork (with tests):

https://github.com/gildorwang/ngQuickDate

Anyone who needs this feature can have a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants